Reshape method #1760
Reshape method #1760
Conversation
artv3
requested review from
MrBurmark,
adayton1,
rhornung67,
mdavis36,
johnbowen42,
rchen20 and
long58
examples/reshape.cpp
Outdated
| // RAJA::Layout objects may be templated on dimension, argument type, and | ||
| // index with unit stride. Here, the column index has unit stride (argument 2). |
There was a problem hiding this comment.
Can you supply the permutation at compile time, via camp::list or std::index_sequence, and have it produce a view with the right unit stride index?
There was a problem hiding this comment.
yes, I pushed a version for that just now. Let me know what you think.
| struct layout_left{}; | ||
| struct layout_right{}; | ||
|
|
||
| template<typename LAYOUT> |
There was a problem hiding this comment.
Can we add a specialization for a generic index sequence like std::index_sequence?
There was a problem hiding this comment.
Sure, I'll take a pass at this and then I'll remove the "Draft" marking from this PR.
|
@MrBurmark , @rhornung67 I think the example for the reshape method can be simplified. I just pushed up a new version. I was a bit worried the previous version might have too much going on. |
| } | ||
|
|
||
| template<std::size_t...Is> | ||
| struct Reshape<std::index_sequence<Is...>> |
There was a problem hiding this comment.
@MrBurmark , this is the specialization that takes an index_sequence and identifies the correct unit stride
| // Initialize memory using right most unit stride | ||
| // | ||
| //----------------------------------------------------------------------------// | ||
| std::cout << "\n\nInitialize array with right most indexing...\n"; |
There was a problem hiding this comment.
I think these implementations are much easier to understand if your intent is just to show the mechanics of View reshaping. 👍
|
|
||
| constexpr auto unit_stride = get_first_index<Is...>(); | ||
|
|
||
| return RAJA::View<T, RAJA::Layout<N, RAJA::Index_type, unit_stride>> |
There was a problem hiding this comment.
Bug found here! unit_stride should be the last value of the prameter pack -- TODO: FIX
Summary
This PR adds helper methods to views to create Reshape methods with compile time options C and Fortran style indexing