Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ccache for CI #977

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Use ccache for CI #977

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dd92d4d
Update BLT to support ccache
davidbeckingsale Mar 4, 2021
c4cc486
Enable ccache for toss3 builds
davidbeckingsale Mar 4, 2021
f9d82de
Merge branch 'develop' into feature/ccache
rhornung67 Mar 5, 2021
47261a1
Merge branch 'develop' into feature/ccache
rhornung67 Mar 5, 2021
349df88
Merge branch 'develop' into feature/ccache
rhornung67 Mar 12, 2021
7ed4780
Merge branch 'develop' into feature/ccache
rhornung67 Mar 15, 2021
9923267
Merge branch 'develop' into feature/ccache
rhornung67 Mar 16, 2021
b7653ee
Merge branch 'develop' into feature/ccache
rhornung67 Mar 22, 2021
eaf03bd
Merge branch 'develop' into feature/ccache
rhornung67 Mar 22, 2021
7ad9c15
Merge branch 'develop' into feature/ccache
rhornung67 Mar 25, 2021
38a1847
Merge branch 'develop' into feature/ccache
rhornung67 Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blt
Open in desktop
Submodule blt updated 17 files
+50 −0 .gitlab-ci.yml
+24 −0 .gitlab/build_and_test.sh
+52 −0 .gitlab/build_lassen.yml
+63 −0 .gitlab/build_quartz.yml
+8 −0 .mailmap
+8 −7 RELEASE-NOTES.md
+1 −0 cmake/BLTOptions.cmake
+68 −5 cmake/BLTPrivateMacros.cmake
+11 −0 cmake/SetupCompilerOptions.cmake
+26 −0 docs/tutorial/unit_testing.rst
+2 −2 host-configs/llnl/toss_3_x86_64_ib/[email protected]
+3 −3 host-configs/llnl/toss_3_x86_64_ib/[email protected]
+62 −0 tests/ctest-to-junit.xsl
+9 −0 tests/internal/CMakeLists.txt
+28 −0 tests/internal/src/hip_defines_test/CMakeLists.txt
+13 −0 tests/internal/src/hip_defines_test/bar.cpp
+13 −0 tests/internal/src/hip_defines_test/foo.cpp
17 changes: 13 additions & 4 deletions scripts/gitlab/build_and_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,19 @@ then
rm -rf ${build_dir} 2>/dev/null
mkdir -p ${build_dir} && cd ${build_dir}

cmake \
-C ${hostconfig_path} \
${project_dir}
cmake --build . -j 32
if [[ ${sys_type} == *toss_3* ]]; then
cmake \
-DENABLE_CCACHE=ON \
-DCCACHE_DIR=/collab/usr/global/tools/ccache/toss_3_x86_64_ib/ccache-4.2/bin/ccache \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ccache work well with a single location that may be targeted by several builds simultaneously? (Maybe it creates a unique subdir per configuration hash?)
Also, in the log I see:

CMake Warning:
  Manually-specified variables were not used by the project:
    CCACHE_DIR

Are we sure this is taken into account by BLT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that's the binary location, not the location of the data...

Then, where is the data stored? If it's in the working directory, then I'm afraid this won't help much. That's because the working directory changes with the runner hash, the job rank on the runner (0 to 7), and then we have no guarantee that the same target will be rebuilt there.

This is not a lost cause though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a typo in my BLT changes :D and we can change the location via a config file. I am trying to work out the best way to set up the config, I think we will need to it via env var.

-C ${hostconfig_path} \
${project_dir}
cmake --build . -j 32
else
cmake \
-C ${hostconfig_path} \
${project_dir}
cmake --build . -j 32
fi
fi

# Test
Expand Down