Draft: Add SW4CK kernels #317
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artv3
commented
Mar 20, 2023
|
Kernel 2 is fine. On Mar 20, 2023, at 12:59 PM, Arturo Vargas ***@***.***> wrote:
@artv3 commented on this pull request.
In src/apps/CMakeLists.txt:
@@ -80,7 +80,9 @@ blt_add_library(
PRESSURE-Hip.cpp
PRESSURE-Cuda.cpp
PRESSURE-OMP.cpp
- PRESSURE-OMPTarget.cpp
+ PRESSURE-OMPTarget.cpp
+ SW4CK_KERNEL_2.cpp
+ SW4CK_KERNEL_2-Seq.cpp
@Ram3sh do the kernels have a formal name? or is Kernel 2 okay?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
artv3
commented
Apr 5, 2023
| const int kfirst = 0; | ||
| const int kstart = 0; | ||
| const int klast = 1; | ||
| const int kend = 1; |
There was a problem hiding this comment.
@Ram3sh, looking at the SW4CK src I think I see various options for problem size dimensions. Would you be able to advise what the values here should be? Or some values that we can use to scale the problem?
artv3
commented
Apr 5, 2023
src/apps/SW4CK_KERNEL_2-Seq.cpp
Outdated
| const int kfirst = 0; | ||
| const int kstart = 0; | ||
| const int klast = 1; | ||
| const int kend = 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SW4CK kernels 2 and 5 as they exhibit a performance gap between RAJA and "native variants".
Source https://github.com/LLNL/SW4CK.