Do not backpropagate through layers without gradient sources #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvanessen
reviewed
Feb 6, 2024
src/models/model.cpp
Outdated
|
|
||
| // Second, check the layer itself. If frozen, backprop is not necessary. | ||
| if (l->is_frozen()) { | ||
| return true; |
There was a problem hiding this comment.
@tbennun Is the sense of this flag inverted? the comment does not seem to match the boolean value.
There was a problem hiding this comment.
This is a mistake, thank you for noticing!
|
Patch is ready and working |
benson31
approved these changes
Feb 7, 2024
bvanessen
approved these changes
Feb 8, 2024
|
@tbennun Does it past CI? |
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks layers that do not need to be computed on backpropagation and skips those. Disable with
LBANN_NO_BACKPROP_DISABLE=1.