Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible configuration of the superbuild location #2426

Merged
merged 169 commits into from
Sep 3, 2024

Conversation

bvanessen
Copy link
Collaborator

Adding some flexibility in the customized_build_env script to make the
location of the external superbuild dependencies easily relocatable.

@bvanessen bvanessen force-pushed the bugfix_relocatable_superbuild branch from 9c535bd to 75ac038 Compare February 15, 2024 21:43
@bvanessen bvanessen requested review from benson31 and tbennun April 10, 2024 16:28
@bvanessen bvanessen force-pushed the bugfix_relocatable_superbuild branch from d3285b5 to 91b0054 Compare June 13, 2024 20:51
@bvanessen bvanessen marked this pull request as ready for review June 17, 2024 22:10
bvanessen added 25 commits July 31, 2024 12:17
location of the external superbuild dependencies easily relocatable.
…sted prefix path. Fixed bug where the forwarded CMAKE_PREFIX_PATH was overwritten when a package dependend on other packages.
bvanessen and others added 27 commits August 20, 2024 10:18
same setup file as the CI runs.  Fixed the build issues for CI on
corona.  Removed scripts for building DHA and LBANN manually (outside
of CI).
time, the Lua module file will now activate it when loaded. Removed
the TCL module file since it wasn't being used by systems.

Added a prompt name to the python venv.

Fixed an empty variable field in the Lassen gitlab code that deleted
other variables.
deactivate an active environment before loading the LBANN module.
Copy link
Collaborator

@benson31 benson31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

Comment on lines +146 to +147
file(WRITE "${CMAKE_INSTALL_PREFIX}/logs/lbann_sb_suggested_cmake_prefix_path.sh"
"export CMAKE_PREFIX_PATH=${LBANN_SB_SUGG_CMAKE_PREFIX_PATH}\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a second copy?

Comment on lines +160 to +163
file(APPEND "${CMAKE_INSTALL_PREFIX}/logs/lbann_sb_suggested_cmake_prefix_path.sh"
"export AWS_OFI_RCCL_LIBDIR=${LBANN_SB_AWS_OFI_RCCL_PREFIX}/lib\n")
file(APPEND "${CMAKE_INSTALL_PREFIX}/logs/lbann_sb_suggested_cmake_prefix_path.sh"
"export LD_LIBRARY_PATH=${LBANN_SB_AWS_OFI_RCCL_PREFIX}/lib:\$\{LD_LIBRARY_PATH\}\n")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a second copy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In multiple places we write out to a version of the file in two different locations. Primarily because I don't know how to write one file and then copy it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what I was asking was "why do we need 2 copies?"

@bvanessen bvanessen merged commit ead9cce into LLNL:develop Sep 3, 2024
1 check passed
@bvanessen bvanessen deleted the bugfix_relocatable_superbuild branch September 3, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants