Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Testing and Assessment #319

Merged
merged 16 commits into from
Dec 20, 2024
Merged

Performance Testing and Assessment #319

merged 16 commits into from
Dec 20, 2024

Conversation

ldowen
Copy link
Collaborator

@ldowen ldowen commented Dec 13, 2024 •
edited
Loading

Summary

  • It does the following:
    • Finalizes performance testing structure
    • Adds scripts to automate performance analysis
    • Integrates performance tests in the CI
    • Fixes bugs in tests

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#118)
  • LLNLSpheral PR has passed all tests.

jmpearl and others added 9 commits December 5, 2024 21:38
@jmpearl
fixing Noh tests for MFV and FSISPH
29711ac 
fsisph had a bad input, mfv needed the update in the GSPHHydros.py file for the new H-update package paradigm
@jmpearl
updating CRKSPH constructor in Noh 3d
045d728
@ldowen
Changed timer_start to timer_begin, added more performance tests, add…
5041f3e 
…ed functions to estimate number of SPH nodes for cylindrical distributions, added git hash, spheral version, and git branch to adiak data
@ldowen
Merge branch 'bugfix/gsph_fsisph_ci_fix' into feature/perf_assess
4f16696
@ldowen
Fix bugs in tests, add multiple test runs for ci tests of performance
e3023c5
@ldowen
Fix more bugs in tests
e5fef7e
@ldowen
Fix TaylorImpact directory bug from previous commit
87e953b
@ldowen
Removed unused CXXTests files, added documentation for running perfor…
aad13c2 
…mance tests, reconfigured how benchmark data directory is stored and passed around, moved performance_analysis.py from scripts/gitlab to scripts/devtools, added new Adiak metadata
@ldowen
Merge branch 'develop' into feature/perf_assess
6ef2ac6
@ldowen ldowen requested review from jmikeowen and mdavis36 December 13, 2024 22:57
@ldowen ldowen self-assigned this Dec 13, 2024
@ldowen ldowen marked this pull request as draft December 13, 2024 23:00
@ldowen
Add cmake function for installing python tests, make performance.py a…
cdd1e72 
…lways be installed in top tests directory in installation, add call in performance.py for llnlperformance.py
@ldowen
Fix test path for performance.py
e787c7a
@ldowen
Fix cmake bugs
4b986f3
@ldowen
Added performance_analysis.py to scripts install directory, added --t…
7de2f5b 
…hreads option to spheral_ats for use in performance.py, removed MPI restriction for performance.py and added logic to thread all cores in that case, added Solid SPH Taylor Impact test configuration, changed 1 and 2 thread 3D convection performance test to just be a single general test, changed all gitlab builds to use -DENABLE_TIMER, updated performance_analysis to better handle non-benchmark reference data, updated documentation accordingly
@ldowen
Removed old docs related to spheral-atstest, fixed bug in performance…
7a37aeb 
…_analysis
@ldowen ldowen marked this pull request as ready for review December 19, 2024 00:32
@ldowen ldowen merged commit 9a039f7 into develop Dec 20, 2024
2 checks passed
@ldowen ldowen deleted the feature/perf_assess branch December 20, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdavis36 mdavis36 mdavis36 approved these changes

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees

@ldowen ldowen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ldowen @jmikeowen @mdavis36 @jmpearl