Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filedialog Enhancements #7575

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

khoidauminh
Copy link
Contributor

@khoidauminh khoidauminh commented Nov 11, 2024

This PR attempts to improve the File Dialog UX by doing the following things:

- [ ] Remember the last opened directories above across different LMMS sessions. I think this won't be needed, and can be implemented later if useful.

@Rossmaxx
Copy link
Contributor

One flaw i could notice was regarding the zyn submodule. Looks like you forgot a recursive submodule update.
So basically, checkout to master, do git submodule update --recursive and checkout back to your branch. Then commit. The submodules should be fixed.

I've been having this thought for some time about using QFileDialog(and other such classes) directly without the inheritance, don't know if it's possible, if possible, that would be the better route. Beyond scope of this PR, but wanted to ask, would it reduce any functionality?

@khoidauminh
Copy link
Contributor Author

Thanks for the correction!

I've been having this thought for some time about using QFileDialog(and other such classes) directly without the inheritance, don't know if it's possible, if possible, that would be the better route. Beyond scope of this PR, but wanted to ask, would it reduce any functionality?

I think it's possible to drop FileDialog and rework this PR so that no functionality is lost. After all I'm only using FileDialog to encapsulate the OperationPaths code.

@khoidauminh khoidauminh marked this pull request as ready for review December 25, 2024 13:30
@khoidauminh
Copy link
Contributor Author

I believe this PR is ready for review. (Sorry for the duplicated commits, had a brainfart and messed up my branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants