-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filedialog Enhancements #7575
base: master
Are you sure you want to change the base?
Filedialog Enhancements #7575
Conversation
One flaw i could notice was regarding the zyn submodule. Looks like you forgot a recursive submodule update. I've been having this thought for some time about using QFileDialog(and other such classes) directly without the inheritance, don't know if it's possible, if possible, that would be the better route. Beyond scope of this PR, but wanted to ask, would it reduce any functionality? |
Thanks for the correction!
I think it's possible to drop FileDialog and rework this PR so that no functionality is lost. After all I'm only using FileDialog to encapsulate the |
I believe this PR is ready for review. (Sorry for the duplicated commits, had a brainfart and messed up my branch) |
This PR attempts to improve the File Dialog UX by doing the following things:
- [ ] Remember the last opened directories above across different LMMS sessions.I think this won't be needed, and can be implemented later if useful.