Reapply "Major German translation rework (01/12/2024) (#7612)" (#7628) #7631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #7628, which reverted #7612, which updated German translations.
I believe there was nothing wrong with my German translation update and the revert was done in error, made for bad reasons. Please bring it back.
The main reasons given for the revert:
lupdate
myself (see Major German translation rework (01/12/2024) #7612 for details) and tested it in-application. The revert PR did not provide testing or evidence for breakageI just tested my PR again and it still works as expected.
If you believe there is anything wrong with the PR, please point out the errors. Because I don't see them.
Again, this was the
lupdate
line I used:If you're aware of a more "complete"
lupdate
line, please let me know. I think thelupdate
line is the crux of this entire problem, because this is the one that collects all the strings. But even this line collects about 3200 strings and it looks quite complete to me in testing. Note the German translation is not 100% complete due to some very difficult strings that are hard to translate.@kawogi @sakertooth