Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Houdini support #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AlexeySmolenchuk
Copy link

@AlexeySmolenchuk AlexeySmolenchuk commented Jan 16, 2024

Added multiplatform CMake for Houdini with HDAs generation.
Screenshot 2024-01-16 042252

Generates ready-to-go release with this structure:
Screenshot 2024-01-16 042518

Everything seems to be working. The only issue is noisy Warnings of unknown "Notes" parameters.
Screenshot 2024-01-16 042803

Compilation is simple as this:

mkdir build
cd build
cmake ..
cmake --build . --target install --config Release

@mprater
Copy link
Member

mprater commented Jan 16, 2024

Thanks for this Alexey. I use the Notes parameter as a placeholder for general information about the shader, and as a place for users to make their own annotations about how they're using the plugin. Since the Notes parameter value is never used or accessed by the plugin, I don't include it in the pTable, but of course it is in the .args file. Do you think the warning has something to do with that? Katana doesn't complain about this and I don't use Houdini, so I'm not sure if this might be the issue or not.

@AlexeySmolenchuk
Copy link
Author

I'm not sure if this might be the issue or not.

For testing/experimenting purposes it's fine.

@mprater
Copy link
Member

mprater commented Jan 17, 2024

I'm going to focus on the terminator issue first. CMake is not within my domain of expertise, so I'll need to have someone else take a look at this before I can consider pulling it. The other consideration is that the purpose of this repo is to provide the response functions themselves rather than a multi-platform build system to compile them. I only provided one at all so they could be easily tested and verified without too much effort. Since the responses need to be integrated into a aggregated set of surface responses to be of practical use, I'm not sure how beneficial building the plugins as they are really is.

@AlexeySmolenchuk
Copy link
Author

Don't worry. Reject if you don't need it.

@mprater
Copy link
Member

mprater commented Jan 17, 2024

Alright, thanks Alexey. I really appreciate your interest. I'm going to leave this PR open for now, as I'd like to use it as an example to help me learn more about CMake.

Also, if you'd like to see these responses added to those that ship with RenderMan Lama, let Pixar know of your interest. I don't know if they've made a decision about that yet or not.

Thanks, mitch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants