Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add preparation for serverside localisation #129

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

add preparation for serverside localisation #129

wants to merge 6 commits into from

Conversation

Apfelwurm
Copy link
Member

@Apfelwurm Apfelwurm commented Jul 7, 2022 •
edited
Loading

#114

missing:

  • fix rebase
  • move GetSystemSettings and GetSystemSetting logic to SystemSettingsManager
  • Tests

@Apfelwurm Apfelwurm marked this pull request as ready for review July 7, 2022 19:26
@Apfelwurm Apfelwurm requested a review from TheR00st3r July 7, 2022 19:26
@Apfelwurm Apfelwurm mentioned this pull request Jul 7, 2022
Open
@Apfelwurm Apfelwurm marked this pull request as draft July 7, 2022 21:16
@Apfelwurm Apfelwurm removed the request for review from TheR00st3r July 7, 2022 21:17
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

52.4% 52.4% Coverage
0.0% 0.0% Duplication

@Apfelwurm Apfelwurm force-pushed the feature/serverlocalisation branch from 601de36 to cd29af7 Compare January 11, 2023 18:06
@Apfelwurm Apfelwurm force-pushed the feature/serverlocalisation branch 2 times, most recently from 33d2306 to fc356d9 Compare January 11, 2023 18:45
@Apfelwurm Apfelwurm force-pushed the feature/serverlocalisation branch from fc356d9 to a303e75 Compare January 11, 2023 18:49
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

56.5% 56.5% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Apfelwurm