This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
LIVE-1004 Hedera integration #1887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- designate a custom deriviation as the bolos app does not support hardened paths - define methods for querying accounts by key and balance with the mirror and node respectively - implement scanAccounts and sync using the mirror and node APIs + operations should always hold a positive value (even for "send" operations) + fake blockHeight to show operations as confirmed + add the concept of a virtualAddress and use for Hedera, a set virtual address will directly render it during receive and warn the user that it cannot be verified
… is a node payment
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
… to false Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Reason(s) for changing `freezeWith(getClient())` with `freeze()` & `.setNodeAccountIds([new AccountId(3)])`:
- Using `freezeWith(getClient())` where `getClient()` is `hedera.Client.forMainnet()` OR `hedera.Client.forNetwork({MAINNET_NETWORK})` will create a bug where the `TransferTransaction` will have 18 members in both its `_nodeIds` and `_signedTransactions`.
- The 18 members in `_nodeIds` are nodes `0.0.3` ~> `0.0.20` and the 18 members in `_signedTransactions` are one of the same of the body bytes to be signed.
- The problem with this bug is that it will loop prompt the user 18 times on the ledger device to confirm the transaction and once that's exhaustedly done, it inevitably fails.
- Setting `setNodeAccountIds()` to an array containing more than one `AccountId` will yield the same prompt loop problem mentioned above.
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
… Fee step Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
Signed-off-by: Jack Ta <[email protected]>
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
self-requested a review
henri-ly
reviewed
May 16, 2022
|
LGTM ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context (issues, jira)
https://ledgerhq.atlassian.net/browse/LIVE-1004
Description / Usage
Hedera integration in Ledger Live - add accounts / sync / send / receive
Expectations