Live release + libcore 4.2

.circleci/build_lib.sh

@@ -55,6 +55,7 @@ function command_ios {
     export OSX_SYSROOT=iphoneos
   else
     export TOOLCHAIN_NAME='ios-nocodesign-14-0-dep-9-3'
+
     export OSX_SYSROOT=iphonesimulator
     export ARCH=x86_64
     #Copy iphone.cmake which is not forcing CMAKE_OSX_SYSROOT to iphoneos in cache

.circleci/config.yml

@@ -314,10 +314,6 @@ jobs:
         name: Submodule_Initialization
         command: |
           . .circleci/init_submodules.sh
-    - run:
-        name: Publish_jar
-        command: |
-          . .circleci/publish_jar.sh
     - store_artifacts:
         path: ~/lib-ledger-core-artifacts
   generate_doc:

.circleci/deploy.sh

@@ -1,5 +1,5 @@
 #!/usr/bin/env bash
-if [ -n "$CIRCLE_TAG" ] || [ "$CIRCLE_BRANCH" == "master" -o "$CIRCLE_BRANCH" == "develop" ] || [ "$CIRCLE_BRANCH" == "nrt" ] || [ "$CIRCLE_BRANCH" == "nrt_jdk8" ] ; then
+if [ -n "$CIRCLE_TAG" ] || [ "$CIRCLE_BRANCH" == "master" -o "$CIRCLE_BRANCH" == "develop" ] || [ "$CIRCLE_BRANCH" == "live_4.2" ]; then
 	cd ../lib-ledger-core-artifacts
 	ls -la
 	aws s3 sync ./ s3://ledger-lib-ledger-core/$LIB_VERSION/ --acl public-read && \

.circleci/deploy_fat_lib.sh

@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 
-if [ -n "$CIRCLE_TAG" ] || [ "$CIRCLE_BRANCH" == "master" -o "$CIRCLE_BRANCH" == "develop" ]; then
+if [ -n "$CIRCLE_TAG" ] || [ "$CIRCLE_BRANCH" == "master" -o "$CIRCLE_BRANCH" == "develop" ] || [ "$CIRCLE_BRANCH" == "live-prerelease" ] || [ "$CIRCLE_BRANCH" == "live_4.2" ]; then
 	cd ../lib-ledger-core-artifacts/ios
 
 	echo "======> Build Fat Library"

.circleci/init_submodules.sh

@@ -26,7 +26,3 @@ git submodule update -- core/src/wallet/algorand/thirdparty/msgpack-c || echo "=
 
 #should checkout leveldb bitcoin-fork branch on leveldb submodule
 cd $HOME/lib-ledger-core/core/lib/leveldb && git checkout bitcoin-fork
-
-echo "========> Generate ITFs"
-cd $HOME/lib-ledger-core
-./tools/generate_interfaces.sh || ./tools/generate_interfaces.sh

.dockerignore

@@ -0,0 +1,14 @@
+.vscode/
+.idea/
+.DS_Store
+.circleci/
+build/
+**/*.md
+**/*.yml
+*.a
+playground/
+.git/
+ledger-core-sample/
+Dockerfile*
+CMakeCache.txt
+Testing/

CHANGELOG.md

@@ -1,3 +1,12 @@
+## 4.2.0
+> 2021/04/19
+
+- Algorand update
+- Stargate protocol update for cosmos
+
+## 4.1.0
+> 2021/02/26 Tezos for NRT
+
 ## 4.0.0
 > 2021/02/12 NRT
 
@@ -17,6 +26,18 @@
 - Fix XRP incremental synchronization
 - Improve runtime performances by splitting db connections between Write pool and Read pool
 - use of tx "id" field (if present) instead of "hash" for btc explorers
+## 3.5.2
+
+> 2021/02/03
+
+- Add AddERC20Accounts API
+
+## 3.5.1
+
+> 2021/01/29
+
+- Remove ERC20 balance check on libcore side
+
 
 ## 3.5.0
 

CMakeLists.txt

@@ -11,7 +11,7 @@ include(UseBackportedModules)
 
 # The project version number.
 set(VERSION_MAJOR   4   CACHE STRING "Project major version number.")
-set(VERSION_MINOR   0   CACHE STRING "Project minor version number.")
+set(VERSION_MINOR   2   CACHE STRING "Project minor version number.")
 set(VERSION_PATCH   0   CACHE STRING "Project patch version number.")
 mark_as_advanced(VERSION_MAJOR VERSION_MINOR VERSION_PATCH)
 

appveyor.yml

@@ -2,7 +2,7 @@ version: 1.0.{build}
 image:
 - Visual Studio 2017
 environment:
-  LIB_VERSION: 4.0.0 # Hardcode the LIB_VERSION : should be retrieved by building libcore node module and run tests/lib_version.js
+  LIB_VERSION: 4.2.0 # Hardcode the LIB_VERSION : should be retrieved by building libcore node module and run tests/lib_version.js
   nodejs_version: "9"
   appveyor_rdp_password:
     secure: jb1LsDmcxCww7tA38S3xSw==
@@ -57,8 +57,8 @@ install:
 - ssh-keygen -y -f c:\users\appveyor\.ssh\id_rsa > c:\users\appveyor\.ssh\id_rsa.pub
 
 #Install openssl
-- ps: Start-FileDownload 'http://slproweb.com/download/Win64OpenSSL-1_1_1j.exe'
-- ps: Start-Process "Win64OpenSSL-1_1_1j.exe" -ArgumentList "/silent /verysilent /sp- /suppressmsgboxes" -Wait
+- ps: Start-FileDownload 'http://slproweb.com/download/Win64OpenSSL-1_1_1k.exe'
+- ps: Start-Process "Win64OpenSSL-1_1_1k.exe" -ArgumentList "/silent /verysilent /sp- /suppressmsgboxes" -Wait
 
 #Install Node
 - ps: Install-Product node $env:nodejs_version
@@ -136,6 +136,8 @@ after_build:
   - set should_deploy=false
   - if %APPVEYOR_REPO_BRANCH%==develop set should_deploy=true
   - if %APPVEYOR_REPO_BRANCH%==master set should_deploy=true
+  - if "%APPVEYOR_REPO_BRANCH%"=="live-prerelease" set should_deploy=true
+  - if "%APPVEYOR_REPO_BRANCH%"=="live_4.2" set should_deploy=true
   - if %APPVEYOR_REPO_TAG%==true set should_deploy=true  #for tests
   - if %should_deploy%==true aws s3 sync ".\%LIB_VERSION%\win\%TOOL_CONFIG%" "s3://ledger-lib-ledger-core/%DEPLOY_VERSION%/win/%TOOL_CONFIG%" --acl public-read
 

cmake/cmake-4.0.0-modules/RequireOutOfSourceBuild.cmake

@@ -25,17 +25,17 @@ set(_test)
 
 if(NOT "${_bin_len}" GREATER "${_src_len}")
 	list(APPEND _test _src)
-	#message(STATUS "Checking ${_src}")
+	message(STATUS "Checking ${_src}")
 endif()
 
 if(NOT "${_bin_len}" GREATER "${_cur_src_len}")
 	list(APPEND _test _cur_src)
-	#message(STATUS "Checking ${_cur_src}")
+	message(STATUS "Checking ${_cur_src}")
 endif()
 
 foreach(_var ${_test})
 	string(SUBSTRING "${${_var}}" 0 ${_bin_len} _chopped)
-	#message(STATUS "comparing ${_bin} and ${_chopped}")
+	message(STATUS "comparing ${_bin} and ${_chopped}")
 	if("${_bin}" STREQUAL "${_chopped}")
 		get_filename_component(_parent "${CMAKE_SOURCE_DIR}/.." ABSOLUTE)
 		message(FATAL_ERROR

core/idl/cosmos/addresses.djinni

@@ -8,8 +8,10 @@ CosmosCurve = enum {
 CosmosBech32Type = enum {
 	PUBLIC_KEY;
 	PUBLIC_KEY_VAL;
+	PUBLIC_KEY_VAL_CONS;
 	ADDRESS;
 	ADDRESS_VAL;
+	ADDRESS_VAL_CONS;
 }
 
 CosmosLikeNetworkParameters = record {
@@ -19,8 +21,10 @@ CosmosLikeNetworkParameters = record {
 	MessagePrefix: string;
 	# Version of the Extended Public Key standard.
 	XPUBVersion: binary;
-	# Prefix useful during implicit address construction from pubKey hash
+	# Prefix useful for bech32 encoding of secp256k1 raw pubKey
 	PubKeyPrefix: binary;
+	# Prefix useful for bech32 encoding of ed25519 raw pubKey
+	Ed25519PubKeyPrefix: binary;
 	# Prefix useful during originated address construction from pubKey hash
 	AddressPrefix: binary;
         # Chain ID of the network

core/idl/errors.djinni

@@ -105,6 +105,9 @@ ErrorCode = enum {
     # Stellar errors
     invalid_stellar_address_format;
     invalid_stellar_memo_type;
+
+    # Tezos errors
+    invalid_self_tx;
 }
 
 Error = record {

core/idl/preferences/preferences.djinni

@@ -89,7 +89,7 @@ PreferencesChange = record {
 }
 
 # Interface describing the behaviour of the backend used by Preferences.
-PreferencesBackend = interface +j +o +n {
+PreferencesBackend = interface +c {
     # Gets the value associated to the given key.
     # @param key The data key.
     # @return The value associated to the key if it exists, an empty option otherwise.

core/idl/wallet/configuration.djinni

@@ -7,6 +7,7 @@ StellarConfiguration = interface +c {
 
 # Available API to use with explorers.
 BlockchainExplorerEngines = interface +c {
+    const STARGATE_NODE: string = "STARGATE_NODE";
     const COSMOS_NODE: string = "COSMOS_NODE";
     const LEDGER_API: string = "LEDGER_API";
     const RIPPLE_API: string = "RIPPLE_API";
@@ -17,6 +18,7 @@ BlockchainExplorerEngines = interface +c {
 
 # Available API to use with observers.
 BlockchainObserverEngines = interface +c {
+    const STARGATE_NODE: string = "STARGATE_NODE";
     const COSMOS_NODE: string = "COSMOS_NODE";
     const LEDGER_API: string = "LEDGER_API";
     const RIPPLE_NODE: string = "RIPPLE_NODE";

core/idl/wallet/cosmos/validators.djinni

@@ -11,6 +11,7 @@ CosmosLikeValidatorDescription = record {
         moniker: string;
         identity: optional<string>;
         website: optional<string>;
+        securityContact: optional<string>;
         details: optional<string>;
 }
 
@@ -63,5 +64,6 @@ CosmosLikeValidator = record {
     # Consensus public key (cosmosvalconspub)
     consensusPubkey: string;
     # Status (Unbonded - Unbonding - Bonded) Goes from 0 to 2 or 1 to 3 depending on API (see https://github.com/cosmos/cosmos-sdk/commit/53bf2271d5bac054a8f74723732f21055c1b72d4#diff-f54554903608b8b89649f532c8f1a78cL43)
-    activeStatus: i32;
+    # For Stargate, the string is an UPPERCASE_CONSTANT
+    activeStatus: string;
 }

core/idl/wallet/cosmos/wallet.djinni

@@ -223,7 +223,7 @@ CosmosLikeRedelegationEntry = interface +c {
 }
 
 CosmosConfigurationDefaults = interface +c {
-        const COSMOS_DEFAULT_API_ENDPOINT: string = "https://cosmos.coin.ledger.com";
+        const COSMOS_DEFAULT_API_ENDPOINT: string = "https://cosmoshub4.coin.ledger.com";
         const COSMOS_OBSERVER_WS_ENDPOINT: string = "";
 }
 

core/idl/wallet/ethereum/erc20.djinni

@@ -32,12 +32,6 @@ ERC20LikeAccount = interface +c {
     getBalanceHistoryFor(start: date, end: date, period: TimePeriod): list<BigInt>;
     # Get the list of operations performed on this ERC20 account.
     getOperations(): list<ERC20LikeOperation>;
-    # Get ERC20 operation by uid
-    getOperation(uid: string, callback: Callback<ERC20LikeOperation>);
-    # Get all ERC20 operations
-    getAllOperations(from: i32, to: i32, ascending: bool, callback: ListCallback<ERC20LikeOperation>);
-    # Get ERC20 operations from a given block height (included), it also returns mempool operations
-    getOperationsFromBlockHeight(from: i32, to: i32, fromBlockHeight: i64, callback: ListCallback<ERC20LikeOperation>);
     # Retrieve raw data concerning a transaction of a given amount to a given address.
     getTransferToAddressData(amount: BigInt, address: string, data: Callback<binary>);
     queryOperations(): OperationQuery;

core/idl/wallet/ethereum/ethereum_like_wallet.djinni

@@ -182,4 +182,8 @@ EthereumLikeAccount = interface +c {
     # The passed addresses are ERC20 accounts
     # Note: same note as above
     getERC20Balances(erc20Addresses: list<string>, callback: ListCallback<BigInt>);
+    # Add ERC20 accounts
+    # The passed addresses are ERC20 accounts
+    # Note: same note as above
+    addERC20Accounts(erc20Addresses: list<string>);
 }

core/idl/wallet/tezos/tezos_like_wallet.djinni

@@ -22,8 +22,14 @@ TezosLikeTransaction = interface +c {
 	getType(): TezosOperationTag;
 	# Get the hash of the transaction.
 	getHash(): string;
-	# Get Fees (in drop)
+	# Get Fees (in drop) 
+	# It returns the sum of transaction fees and reveal fees (if it exists)
 	getFees(): Amount;
+	# get transaction fees (without reveal cost)
+	getTransactionFees(): Amount;
+	# get reveal fees if the sender envolved is not revealed, else 0
+	getRevealFees(): Amount;
+
 	# Get destination XTZ. address
 	getReceiver(): optional<TezosLikeAddress>;
 	# Get XTZ. sender address
@@ -85,8 +91,19 @@ TezosLikeTransactionBuilder = interface +c {
 	wipeToAddress(address: string): TezosLikeTransactionBuilder;
 
 	# Set fees (in drop) the originator is willing to pay
+	# Set transaction and (if needed) reveal fees with 'fees'
+	# equivalent to call both functions setTransactionFees(fees) and setRevealFees(fees)
 	# @return A reference on the same builder in order to chain calls.
 	setFees(fees: Amount): TezosLikeTransactionBuilder;
+
+	# Set transaction fees (in drop) the originator is willing to pay (reveal is not included)
+	# @return A reference on the same builder in order to chain calls.
+	setTransactionFees(transactionFees: Amount): TezosLikeTransactionBuilder;
+
+	# Set reveal fees (in drop) the originator is willing to pay 
+	# @return A reference on the same builder in order to chain calls.
+	setRevealFees(revealFees: Amount): TezosLikeTransactionBuilder;
+
 	# Set gas limit the originator is not willing to exceed.
 	# @return A reference on the same builder in order to chain calls.
 	setGasLimit(gasLimit: Amount): TezosLikeTransactionBuilder;
@@ -105,8 +122,8 @@ TezosLikeTransactionBuilder = interface +c {
 	# Reset the current instance to its initial state
 	reset();
 
-	static parseRawUnsignedTransaction(currency: Currency, rawTransaction: binary): TezosLikeTransaction;
-	static parseRawSignedTransaction(currency: Currency, rawTransaction: binary): TezosLikeTransaction;
+	static parseRawUnsignedTransaction(currency: Currency, rawTransaction: binary, protocolUpdate: string): TezosLikeTransaction;
+	static parseRawSignedTransaction(currency: Currency, rawTransaction: binary, protocolUpdate: string): TezosLikeTransaction;
 }
 
 #Class representing a Tezos account
@@ -126,8 +143,15 @@ TezosLikeAccount = interface +c {
 	getEstimatedGasLimit(address: string, callback: Callback<BigInt>);
 	# Get fees from network
 	getFees(callback: Callback<BigInt>);
+	# Get gas price from network
+	getGasPrice(callback: Callback<BigInt>);
 	# Get originated accounts by current account
 	getOriginatedAccounts(): list<TezosLikeOriginatedAccount>;
+	# Get current delegate
+	getCurrentDelegate(callback: Callback<string>);
+  # Get the balance of the account for a given token
+  # @param tokenAddress Address of the contract
+  getTokenBalance(tokenAddress: string, callback: Callback<BigInt>);
 }
 
 # Class representing originated accounts
@@ -154,27 +178,34 @@ TezosLikeOriginatedAccount = interface +c {
 }
 
 TezosConfiguration = interface +c {
-  	const TEZOS_XPUB_CURVE: string = "TEZOS_XPUB_CURVE";
-	const TEZOS_PROTOCOL_UPDATE: string = "TEZOS_PROTOCOL_UPDATE";
-	const TEZOS_NODE: string = "TEZOS_NODE";
+    const BCD_API: string = "BCD_API";
+    const TEZOS_XPUB_CURVE: string = "TEZOS_XPUB_CURVE";
+    const TEZOS_PROTOCOL_UPDATE: string = "TEZOS_PROTOCOL_UPDATE";
+    const TEZOS_NODE: string = "TEZOS_NODE";
+    const TEZOS_COUNTER_STRATEGY: string = "TEZOS_COUNTER_STRATEGY";
+    const TEZOS_OPTIMISTIC_COUNTER_TIMEOUT: string = "TEZOS_OPTIMISTIC_COUNTER_TIMEOUT";
 }
 
 TezosConfigurationDefaults = interface +c {
-	const TEZOS_DEFAULT_API_ENDPOINT: string = "https://explorers.api.live.ledger.com";
-	const TEZOS_DEFAULT_API_VERSION: string = "v3";
-	const TZSTATS_API_ENDPOINT: string = "https://api.tzstats.com/explorer";
-	const TEZOS_DEFAULT_NODE: string = "https://mainnet.tezrpc.me";
-	const TEZOS_OBSERVER_NODE_ENDPOINT_S3: string = "https://s3.tezos.com";
-	const TEZOS_OBSERVER_WS_ENDPOINT_S2: string = "wss://s2.tezos.com";
-	const TEZOS_OBSERVER_WS_ENDPOINT_S3: string = "wss://s3.tezos.com";
-  	const TEZOS_XPUB_CURVE_ED25519: string = "ED25519";
-  	const TEZOS_XPUB_CURVE_SECP256K1: string = "SECP256K1";
-	const TEZOS_XPUB_CURVE_P256: string = "P256";
-	# Taken from some existing XTZ wallets
-	# http://tezos.gitlab.io/protocols/005_babylon.html#gas-cost-changes
-	const TEZOS_DEFAULT_FEES: string = "5000";
-	const TEZOS_DEFAULT_MAX_FEES: string = "30000";
-	const TEZOS_DEFAULT_GAS_LIMIT: string = "18000";
-	const TEZOS_DEFAULT_STORAGE_LIMIT: string = "300";
-	const TEZOS_PROTOCOL_UPDATE_BABYLON: string = "TEZOS_PROTOCOL_UPDATE_BABYLON";
+    const BCD_API_ENDPOINT: string = "https://api.better-call.dev/v1";
+    const TEZOS_DEFAULT_API_ENDPOINT: string = "https://explorers.api.live.ledger.com";
+    const TEZOS_DEFAULT_API_VERSION: string = "v3";
+    const TZSTATS_API_ENDPOINT: string = "https://api.tzstats.com/explorer";
+    const TEZOS_DEFAULT_NODE: string = "https://mainnet.tezrpc.me";
+    const TEZOS_OBSERVER_NODE_ENDPOINT_S3: string = "https://s3.tezos.com";
+    const TEZOS_OBSERVER_WS_ENDPOINT_S2: string = "wss://s2.tezos.com";
+    const TEZOS_OBSERVER_WS_ENDPOINT_S3: string = "wss://s3.tezos.com";
+    const TEZOS_XPUB_CURVE_ED25519: string = "ED25519";
+    const TEZOS_XPUB_CURVE_SECP256K1: string = "SECP256K1";
+    const TEZOS_XPUB_CURVE_P256: string = "P256";
+    # Taken from some existing XTZ wallets
+    # http://tezos.gitlab.io/protocols/005_babylon.html#gas-cost-changes
+    const TEZOS_DEFAULT_FEES: string = "5000";
+    const TEZOS_DEFAULT_MAX_FEES: string = "30000";
+    const TEZOS_DEFAULT_GAS_LIMIT: string = "18000";
+    const TEZOS_DEFAULT_STORAGE_LIMIT: string = "300";
+    const TEZOS_PROTOCOL_UPDATE_BABYLON: string = "TEZOS_PROTOCOL_UPDATE_BABYLON";
+}
+TezosLikeWallet = interface +c {
+    isDelegate(address: string, callback: Callback<bool>);
 }

core/lib/soci_postgresql/session.cpp

@@ -68,17 +68,17 @@ void hard_exec(PGconn * conn, char const * query, char const * errMsg)
 
 void postgresql_session_backend::begin()
 {
-    hard_exec(conn_, "BEGIN", "Cannot begin transaction.");
+    //hard_exec(conn_, "BEGIN", "Cannot begin transaction.");
 }
 
 void postgresql_session_backend::commit()
 {
-    hard_exec(conn_, "COMMIT", "Cannot commit transaction.");
+    //hard_exec(conn_, "COMMIT", "Cannot commit transaction.");
 }
 
 void postgresql_session_backend::rollback()
 {
-    hard_exec(conn_, "ROLLBACK", "Cannot rollback transaction.");
+    //hard_exec(conn_, "ROLLBACK", "Cannot rollback transaction.");
 }
 
 void postgresql_session_backend::deallocate_prepared_statement(