Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of test key or prod key for PKI #540

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

srasoamiaramanana-ledger
Copy link
Contributor

@srasoamiaramanana-ledger srasoamiaramanana-ledger commented Dec 10, 2024

This PR allows to either load a PKI production certificate or a test certificate for testing purposes. By default, speculos will verify the certificate with a test key, one has to launch speculos with the argument --pki-prod/-p to verify a production certificate.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 43.83%. Comparing base (fde57e3) to head (b604b73).

Files with missing lines Patch % Lines
src/launcher.c 0.00% 4 Missing ⚠️
speculos/main.py 0.00% 3 Missing ⚠️
src/bolos/os_signature.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   43.86%   43.83%   -0.03%     
==========================================
  Files         125      125              
  Lines       12448    12456       +8     
  Branches      993      994       +1     
==========================================
  Hits         5460     5460              
- Misses       6653     6661       +8     
  Partials      335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srasoamiaramanana-ledger srasoamiaramanana-ledger merged commit 68d20b7 into master Dec 10, 2024
40 checks passed
@srasoamiaramanana-ledger srasoamiaramanana-ledger deleted the pki-option branch December 10, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants