Add support for RFB Extension Qemu Key Event #447
Conversation
| }; | ||
| uint32_t nEncodings = sizeof(supported) / sizeof(supported[0]), i; | ||
|
|
||
|
|
There was a problem hiding this comment.
please don't add unrelated whitespace.
| @@ -100,7 +100,7 @@ enum rfbSocketState { | |||
| RFB_SOCKET_SHUTDOWN | |||
| }; | |||
|
|
|||
| typedef void (*rfbKbdAddEventProcPtr) (rfbBool down, rfbKeySym keySym, struct _rfbClientRec* cl); | |||
| typedef void (*rfbKbdAddEventProcPtr) (rfbBool down, rfbKeySym keySym, rfbKeyCode keyCode, struct _rfbClientRec* cl); | |||
There was a problem hiding this comment.
Never ever change existing API - this breaks code for existing users.
| @@ -608,6 +608,7 @@ typedef struct _rfbClientRec { | |||
| rfbBool useRichCursorEncoding; /**< rfbEncodingRichCursor is preferred */ | |||
| rfbBool cursorWasChanged; /**< cursor shape update should be sent */ | |||
| rfbBool cursorWasMoved; /**< cursor position update should be sent */ | |||
| rfbBool enableQemuKeyEvent; /**< client supports QemuKeyEvent */ | |||
There was a problem hiding this comment.
Please add members at the end of the struct to not break ABI.
|
Hi @philenotfound - would love to have an update on this as it would play nicely with #453 |
|
Will look into it.. |
|
Needs rebase, some code changes highlighted above and testing with the client side. |
|
Personally I've a problem with this PR and #453. Just my 2 cents… |
|
@philenotfound do you still want to work on this PR? |
|
I'll probably get to refactoring this in a few weeks. |
Tested against noVNC client.