Fix BLOCKSTRETCHACTION situation after handles #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-josef-spacek
force-pushed
the
fix_blockstretchaction2
branch
from
b34a644 to
e724c9b
Compare
|
No, the name of the num field must be the same as the array, just with the num_ prefix. There's special dynapi logic there |
|
Yes, I see errors in JSON conversions :-) |
michal-josef-spacek
force-pushed
the
fix_blockstretchaction2
branch
from
e724c9b to
e83ca33
Compare
|
@rurban better? |
michal-josef-spacek
force-pushed
the
fix_blockstretchaction2
branch
from
e83ca33 to
4127657
Compare
Last fix was wrong. Each handle could have zero, one or more indexes. Fixes GH#1053
Part of GH#1054
michal-josef-spacek
force-pushed
the
fix_blockstretchaction2
branch
from
4127657 to
107b5e4
Compare
michal-josef-spacek
changed the title
|
@rurban PR is fine from my side :-) |
rurban
requested changes
Dec 5, 2024
I prepared alternative: #1055 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last fix was wrong. Each handle could have zero, one or more indexes.
Fixes GH#1053