No JSON whitespace in release version #887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
=======================================
Coverage 73.77% 73.77%
=======================================
Files 2 2
Lines 122 122
=======================================
Hits 90 90
Misses 32 32 ☔ View full report in Codecov by Sentry. |
|
Wait, I forgot to check the JSON, there's a small issue. |
rurban
reviewed
Dec 3, 2023
rurban
added
cla_needed
|
The JSON issue was not related to this PR. |
rurban
added a commit
that referenced
this pull request
Feb 7, 2024
no whitespace at run-time. We don't write minimal JSON as with minimal DXFs anymore ($ACADVER, $HANDSEED, and then ENTITIES only). With ideas from GH #887
|
I'll be doing it at runtime, by using a minJson format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #886 - (I didn't manage to rebase the original feature branch that I accidentally branched of another feature branch in reasonable time).
I considered this feature as a runtime option, but it would be more work and I don't know how to compile the c file twice to produce the same function with a different flag, without creating a mess.
I could however, make this as an optional DISABLE_JSON_WHITESPACE flag rather than default when DEBUG is not set.
IMHO a sleak release version by default is a more important use case, and therefore should not include unnecessary whitespace or conditionals.
JSON readability is for debugging and should be done by piping, autoformat, setting the flag, 2 variants of each program, or using the debug version.
YAML/JSON5 would more suitable for readability anyway, and could also be done with macro's in out_json, but someone else can do that.