Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg changes #273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Svg changes #273

wants to merge 2 commits into from

Conversation

IsaacPimentel73
Copy link
Contributor

Converting jpg images into svg.

Signed-off-by: IsaacPimentel73 <[email protected]>
Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At cover images is necessary to be jpeg, but we need to apply image compression at all jpeg images, or maybe we can use PNG with compression.

SVG is only to vectorial images like a logo with curves.

SVG images also should be compressed to be used at web context.

Maybe @Zagaz could have a good opinion about usage PNG or jpeg as format of cover images. https://duckduckgo.com/?q=use+jpg+or+png+to+web+images

A suggestion of to-do list to this issue:

Other suggestion to compress image is searching for online websites that do this. By example, search by "online png compression" or "online svg compression".

Copy link
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using this image?

I think that is pending to remove this image, right?!

source/assets/images/posts/advanced-security/cover1.svg

@vitormattos
Copy link
Member

vitormattos commented Dec 3, 2024

SVG is vetorial images. Isn't necessary and isn't good to convert pictures to SVG.
Images that make sense to be a SVG are logos:
https://github.com/LibreSign/site/blob/main/source/assets/images/icon/somoscoop.png
https://github.com/LibreSign/site/blob/main/source/assets/images/logo/logo-libresign-large.png
https://github.com/LibreSign/site/blob/main/source/assets/images/logo/logo_libresign-small.png
But i s necessary to check the places that those images are used and what will be the impact.

Photos need to be maintained as JPG.
Important points about photos:

  • Check if all photos used to posts have the same size and if the size is the same that is necessary to be displayed (not bigger and not lower than the necessary).
  • Compress the jpeg images without losing resolution.

Every when we change an url, is important to check if the URL was indexed at internet to don't break the referred links.

Other important point is to fix the DCO issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants