Start multiple docker containers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmmeans
reviewed
Apr 2, 2024
src/main/scala/com/lifeway/sbt/testdocker/StartTestDocker.scala
Outdated
Show resolved
Hide resolved
|
I'm good with the change. can you update the README for usage and bump the version to 1.1.0? I'm not sure how the version was previously set... |
jordanfjellman
previously approved these changes
Apr 2, 2024
|
I updated the README. Versioning is handle by tags so I'll make sure to tag it appropriately. |
jbellars
approved these changes
Apr 2, 2024
jbellars
suggested changes
Apr 2, 2024
jordanfjellman
approved these changes
Apr 4, 2024
|
@jbellars was right. The readme for what version needs to be updated too. Can someone hit this? @matthewdunbar @jordanfjellman @davidhulse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.