Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup run command output #476

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

bgins
Copy link
Contributor

@bgins bgins commented Dec 18, 2024

Summary

This pull request makes the following changes:

  • Remove ipfs.io URL from run output
  • Add data ID to run output

We will stop storing results in IPFS soon, and the IPFS URL will no longer be valid. It's still useful to view the job outputs CID, so this PR reports that as a Data ID.

Test plan

Start the stack. Run a job using the CLI. Check the output at the end.

Details

CleanShot 2024-12-18 at 11 24 41@2x

@bgins bgins requested a review from a team as a code owner December 18, 2024 19:25
@cla-bot cla-bot bot added the cla-signed label Dec 18, 2024
@bgins bgins self-assigned this Dec 18, 2024
@bgins bgins requested a review from noryev December 18, 2024 19:25
@github-actions github-actions bot added the chore label Dec 18, 2024
Copy link
Contributor

@noryev noryev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2024-12-18 18-07-54
Tested and everything looks great! @bgins

@bgins bgins merged commit 43b5c47 into main Dec 19, 2024
4 checks passed
@bgins bgins deleted the bgins/chore-run-command-output-cleanup branch December 19, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants