-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show YT's AI chat summary in a 'pinned'-style box if it is present #148
Conversation
I personally like that it doesn't interfere with the other pins like the native popup. Hmm do you think we need to make it clear that the AI summary is not a HyperChat feature? |
I think that we should. It can probably be done by just changing “Auto-generated experiment” to something like “auto-generated by YouTube” or “Auto-generated YouTube experiment”, or changing the title from “chat summary” to “chat summary by YouTube”. Though the specific language is up to you |
If someone can grab me the data for non-English YT UI (I bet it sends localized text), we should probably append to the existing text in subheader instead of overwriting it (so that it keeps some level of localization). EDIT: Actually rather than trying to localize maybe it'd be better to just include a (!) icon with a link to https://support.google.com/youtube/thread/18138167?hl=en&msgid=284199217 EDIT2: I've just made the subheader link to the above, way simpler. |
8ec89fa
to
c421d93
Compare
d97a865
to
ccf524a
Compare
@KentoNishi just looping you in, just needs a test and then include in the next release mb? |
my bad for being so late on this, was wrapped up with the iclr deadline. will review soon |
…description on Google's support site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is brilliantly well implemented, i have no complaints whatsoever
@r2dev2 give it a quick scan, if it's good we can initiate the merge process |
what an absolutely fantastic pr @FlaminSarge u absolute legend |
It's not perfect (icon and showtime fields remain unused right now) but it's pretty functional. Collapsing and dismissing both work as intended.
There are some hacky bits involved already to split the runs into header vs subheader vs message, so better ways to handle that would be nice, but YT's format for this action isn't ideal.
I tried adding the iconType stuff, but it resulted in the header being offset by the size of the name of the icon. Was not sure how to resolve.
As far as I can tell YT never sends this as a part of live chat data, only when first loading the chat, but hopefully it works the same if they do add it to live chat data as well.
I did not hook it up to dismiss when YT sends 'unpin' action, as a heads up.
Screenshots:
Setting
With subheader as a link to https://support.google.com/youtube/thread/18138167?hl=en&msgid=284199217 :
Before subheader change, but showing behavior alongside pinned msg: