Implement rudimentary redirect banner #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ided by bannerProperties Also updates the impl in ChatSummary
FlaminSarge
force-pushed
the
redirect
branch
from
5db3732 to
bdec48f
Compare
This didn't affect summary since it never came through the chat interceptor, only on initial load, but will be needed for redirect as well
FlaminSarge
force-pushed
the
redirect
branch
from
bdec48f to
eb1fa02
Compare
Supports send and receive, uses the urlEndpoint or watchEndpoint link to open a new tab with the given url if the button is clicked This also adds support for bold text (but not deemphasized text yet) to MessageRun This does not implement contextMenuButton at all yet, only inlineActionButton.
FlaminSarge
force-pushed
the
redirect
branch
from
eb1fa02 to
e658b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports send and receive, uses the urlEndpoint or watchEndpoint link to open a new tab with the given url if the button is clicked
This also adds support for bold text (but not deemphasized text yet) to MessageRun
This does not implement contextMenuButton at all yet, only inlineActionButton.
Has the same auto-collapse behavior as other banner messages.
Built on top of #156
Very hacky URL handling and button handling at the moment.
"Redirect Notice" is added to the header because it looks a bit silly without anything there.
"Redirect profile photo" is set as the alt text for the image since the author's actual name is only available elsewhere and it would be too hacky to try to grab it.
Tested on mv3 w/ chrome