Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update macro events real-time #294

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

update macro events real-time #294

wants to merge 15 commits into from

Conversation

hanmindev
Copy link
Contributor

@hanmindev hanmindev commented Jul 12, 2023 •
edited
Loading

Blocked by #318

@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 2381c17
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/64efef2beedd800008fc269a
😎 Deploy Preview https://deploy-preview-294--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanmindev hanmindev changed the base branch from main to dev July 12, 2023 05:20
@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 2381c17
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/64efef2bcf79e2000813700c
😎 Deploy Preview https://deploy-preview-294--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Ynng
Ynng requested changes Jul 15, 2023
View reviewed changes
src/pages/macros.tsx Outdated Show resolved Hide resolved
@Ynng
Copy link
Member

Ynng commented Jul 19, 2023

It would be nice if you can get your auto formatting to follow our https://github.com/Lodestone-Team/lodestone/blob/main/dashboard/prettier.config.js
The formatting changes is making the git diff quite hard to read

Ynng
Ynng reviewed Jul 21, 2023
View reviewed changes
dashboard/src/data/EventStream.ts Outdated Show resolved Hide resolved
dashboard/src/data/EventStream.ts Outdated Show resolved Hide resolved
dashboard/src/data/EventStream.ts Show resolved Hide resolved
dashboard/src/data/EventStream.ts Outdated Show resolved Hide resolved
dashboard/src/data/EventStream.ts Outdated Show resolved Hide resolved
dashboard/src/data/EventStream.ts Outdated Show resolved Hide resolved
dashboard/src/pages/macros.tsx Show resolved Hide resolved
dashboard/src/pages/macros.tsx Outdated Show resolved Hide resolved
dashboard/src/pages/macros.tsx Outdated Show resolved Hide resolved
@Ynng Ynng mentioned this pull request Jul 24, 2023
Open
@Ynng Ynng linked an issue Jul 24, 2023 that may be closed by this pull request
Hook up macro event to macro page #273
Open
@Ynng
Copy link
Member

Ynng commented Jul 27, 2023

This is blocked by #318

@Ynng Ynng mentioned this pull request Jul 27, 2023
Closed
@hanmindev hanmindev requested a review from Ynng August 1, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheatCod CheatCod CheatCod left review comments

@Ynng Ynng Awaiting requested review from Ynng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hook up macro event to macro page
3 participants
@hanmindev @Ynng @CheatCod