Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Create new stats module #273

Merged
merged 6 commits into from
May 23, 2019
Merged

[REF] Create new stats module #273

merged 6 commits into from
May 23, 2019

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 24, 2019

Closes #249.

Changes proposed in this pull request:

  • tedana.model.fit.get_coeffs --> tedana.stats.get_coeffs
  • tedana.model.fit.computefeats2 --> tedana.stats.computefeats2
  • tedana.utils.getfbounds --> tedana.stats.getfbounds
  • Update corresponding tests and API documentation.

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #273 into master will increase coverage by 0.26%.
The diff coverage is 78.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage    49.1%   49.36%   +0.26%     
==========================================
  Files          37       39       +2     
  Lines        2122     2133      +11     
==========================================
+ Hits         1042     1053      +11     
  Misses       1080     1080
Impacted Files Coverage Δ
tedana/utils.py 57.28% <ø> (-2.36%) ⬇️
tedana/tests/test_utils.py 100% <ø> (ø) ⬆️
tedana/tests/test_stats_get_coeffs.py 100% <100%> (ø)
tedana/tests/test_stats_getfbounds.py 100% <100%> (ø)
tedana/tests/test_stats_computefeats2.py 100% <100%> (ø)
tedana/io.py 48.42% <33.33%> (+0.54%) ⬆️
tedana/model/fit.py 29.47% <50%> (-9.34%) ⬇️
tedana/selection/tedpca.py 12.9% <50%> (+1.42%) ⬆️
tedana/decomposition/pca.py 16.66% <50%> (+1.17%) ⬆️
tedana/selection/tedica.py 24.8% <50%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1030a69...4ceb295. Read the comment docs.

# Conflicts:
#	tedana/decomposition/eigendecomp.py
#	tedana/selection/__init__.py
@ME-ICA ME-ICA deleted a comment from codecov bot Apr 25, 2019
@ME-ICA ME-ICA deleted a comment from codecov bot Apr 25, 2019
jbteves
jbteves previously approved these changes May 6, 2019
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the guts of what this is doing, but from a refactoring perspective this looks fantastic. I think this helps clean up a lot of the affected lines of code, and it should make testing easier later as we write more tests. Great job, @tsalo !

As a comment unrelated to review approval, it seems like there are a lot of "mysterious numbers" in the code. This PR isn't the place to address that, but I'd like to know what you would think about opening a new issue to fix that. I say "mysterious" instead of the more common "magic" because my hope would be that such an issue would de-mystify their usage. I'll comment on some of those momentarily.

# Conflicts:
#      tedana/model/fit.py
#	tedana/selection/tedpca.py
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsalo tsalo merged commit 0c0d704 into ME-ICA:master May 23, 2019
@tsalo tsalo deleted the reorg-stats branch May 23, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move statistical functions into new stats module
2 participants