-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Create new stats module #273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 49.1% 49.36% +0.26%
==========================================
Files 37 39 +2
Lines 2122 2133 +11
==========================================
+ Hits 1042 1053 +11
Misses 1080 1080
Continue to review full report at Codecov.
|
# Conflicts: # tedana/decomposition/eigendecomp.py # tedana/selection/__init__.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about the guts of what this is doing, but from a refactoring perspective this looks fantastic. I think this helps clean up a lot of the affected lines of code, and it should make testing easier later as we write more tests. Great job, @tsalo !
As a comment unrelated to review approval, it seems like there are a lot of "mysterious numbers" in the code. This PR isn't the place to address that, but I'd like to know what you would think about opening a new issue to fix that. I say "mysterious" instead of the more common "magic" because my hope would be that such an issue would de-mystify their usage. I'll comment on some of those momentarily.
# Conflicts: # tedana/model/fit.py # tedana/selection/tedpca.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #249.
Changes proposed in this pull request:
tedana.model.fit.get_coeffs
-->tedana.stats.get_coeffs
tedana.model.fit.computefeats2
-->tedana.stats.computefeats2
tedana.utils.getfbounds
-->tedana.stats.getfbounds