Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the met script compatible with APCEMM 1.2 #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Calebsakhtar
Copy link
Contributor

@Calebsakhtar Calebsakhtar commented Nov 9, 2024

I noticed that as of version 1.2 the met files produced by the scripts are no longer compatible with APCEMM.

This PR addresses that by:

  • Adding a way to specify the vertical velocity "w".
  • Adding a default entry (populated by ones) for the stretch.
  • Adding a reference time.
  • Removing the water relative humidity.

@Calebsakhtar
Copy link
Contributor Author

Calebsakhtar commented Nov 9, 2024

@sdeastham Would you mind reviewing this?

@Calebsakhtar
Copy link
Contributor Author

@sdeastham Just bumping this

@sdeastham
Copy link
Collaborator

Thanks @Calebsakhtar ! One change request - can you update the units of w in the script to be in Pa s-1, not m/s? The routine now uses pressure-velocity (it's both more convenient for the code and more common as an output from GCMs)

@Calebsakhtar
Copy link
Contributor Author

Hi @sdeastham, I finally got round to doing this. Sorry for combining the commit with the application of Black Formatter. Hopefully it looks better though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants