-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI option to list available modules in mod_dir #15
Open
imjonsnooow
wants to merge
7
commits into
MITRECND:master
Choose a base branch
from
imjonsnooow:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3a4c813
Add -a option to CLI which will list all available modules in the mod…
imjonsnooow 92fff78
Update chopshop docs to detail the -a option.
imjonsnooow 9e52aec
Reset chopshop WD and python loc.
imjonsnooow 4b19a54
Fix documentation.
imjonsnooow 282e22c
Revise module list function not to look in subdirectories of modules …
imjonsnooow 8a86d7f
Print out directory being searched for modules when -a flag is passed.
imjonsnooow 5878aa8
Print out module directory before walking it.
imjonsnooow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to mention -M here.
This doesn't work when using -B though, and it should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If -B is specified, wouldn't mod_dir incorporate that on line 507 of ChopLib.py? Since the added code walks mod_dir, I thought this solution would handle -B. (Definitely correct me if I'm wrong - today is my first time looking at this code.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have thought it would have worked too but it doesn't.
wxs@psh chopshop % ./chopshop -B ~/chopshop_modules -a
It just hangs. I can provide more input if you can not reproduce this. You can probably get away with making a dummy chopshop module and putting it in ~/chopshop_modules/modules to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I attempt the same line (after making that directory), I get "No modules found in directory" as a result, as expected. Could it be an environment issue? I'm testing on OS X 10.8.4.