Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timings + used memory to tests #3285

Merged
merged 6 commits into from
Oct 12, 2023
Merged

add timings + used memory to tests #3285

merged 6 commits into from
Oct 12, 2023

Conversation

SimonDanisch
Copy link
Member

No description provided.

@MakieBot
Copy link
Collaborator

MakieBot commented Oct 10, 2023

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(display(fig))
using create display create display
GLMakie 13.86s (13.72, 14.02) 0.11+- 1.36s (1.35, 1.37) 0.01+- 0.96s (0.94, 1.02) 0.03+- 12.25ms (12.10, 12.40) 0.11+- 186.44ms (185.21, 188.54) 1.30+-
master 13.95s (13.75, 14.16) 0.15+- 1.36s (1.34, 1.37) 0.01+- 947.73ms (938.09, 961.74) 9.09+- 12.32ms (12.21, 12.48) 0.11+- 185.79ms (184.24, 188.32) 1.34+-
evaluation -0.64%, -0.09s invariant (-0.67d, 0.23p, 0.13std) +0.71%, 0.01s invariant (0.90d, 0.12p, 0.01std) +1.08%, 0.01s invariant (0.50d, 0.38p, 0.02std) -0.58%, -0.07ms invariant (-0.65d, 0.24p, 0.11std) +0.35%, 0.65ms invariant (0.49d, 0.38p, 1.32std)
CairoMakie 12.23s (12.08, 12.48) 0.18+- 1.37s (1.34, 1.42) 0.02+- 248.66ms (241.75, 262.59) 7.23+- 15.14ms (14.92, 15.43) 0.16+- 8.32ms (8.23, 8.46) 0.09+-
master 12.30s (12.09, 12.58) 0.18+- 1.41s (1.34, 1.51) 0.06+- 259.36ms (239.81, 296.04) 18.07+- 15.10ms (14.93, 15.31) 0.15+- 8.37ms (8.07, 8.58) 0.16+-
evaluation -0.53%, -0.07s invariant (-0.36d, 0.51p, 0.18std) -2.89%, -0.04s invariant (-0.91d, 0.13p, 0.04std) -4.30%, -10.7ms invariant (-0.78d, 0.18p, 12.65std) +0.25%, 0.04ms invariant (0.24d, 0.66p, 0.16std) -0.67%, -0.06ms invariant (-0.43d, 0.44p, 0.13std)
WGLMakie 13.94s (13.75, 14.14) 0.13+- 1.16s (1.15, 1.18) 0.01+- 12.11s (11.99, 12.21) 0.09+- 16.94ms (14.66, 23.26) 2.91+- 1.09s (1.05, 1.12) 0.03+-
master 13.97s (13.83, 14.16) 0.11+- 1.17s (1.15, 1.19) 0.01+- 12.11s (11.92, 12.40) 0.17+- 15.83ms (15.08, 16.32) 0.42+- 1.06s (1.02, 1.10) 0.03+-
evaluation -0.22%, -0.03s invariant (-0.25d, 0.65p, 0.12std) -1.12%, -0.01s faster ✓ (-1.28d, 0.04p, 0.01std) -0.01%, -0.0s invariant (-0.01d, 0.99p, 0.13std) +6.55%, 1.11ms noisy🤷‍♀️ (0.53d, 0.36p, 1.67std) +2.83%, 0.03s invariant (1.05d, 0.07p, 0.03std)

@ffreyer
Copy link
Collaborator

ffreyer commented Oct 12, 2023

Would be nice to have some colors in this so slow/expensive tests are easy to spot. Just a some simple thresholds like if > 10s; color = :red would be enough for that I think

@SimonDanisch
Copy link
Member Author

I think we should just make a nice report at some point, like the compile time benchmark, maybe even with a plot!
If it stays in the CI, almost nobody will look at it anyways.
I dont really have time for that now though, so I think it will stay like this for now :(

@SimonDanisch SimonDanisch merged commit 513b4ac into master Oct 12, 2023
13 checks passed
@SimonDanisch SimonDanisch deleted the sd/time-tests branch October 12, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants