[WIP] Improvements to PlotSpecs and the SpecAPI #3628
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't allow post facto editing, but e.g. `plot(diffeq_solution; linewidth = 0.1)` will at least work.
Compile Times benchmarkNote, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running: using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
|
asinghvi17
commented
Feb 16, 2024
| @@ -401,6 +401,13 @@ function to_plot_object(ps::PlotSpec) | |||
| return P((ps.args...,), copy(ps.kwargs)) | |||
| end | |||
|
|
|||
| function to_plot_object(ps::PlotSpec, p::PlotList) | |||
| P = plottype(ps) | |||
There was a problem hiding this comment.
What would people think if, knowing the default_theme of P()::Plot here, we populate the missing attributes with their default values as Observables in p::PlotList, so that users can edit them post-facto and have them pass through like normal Observables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a WIP set of improvements/changes to the SpecAPI after some usage.
plot(diffeq_solution; linewidth = 0.1)will at least work).More changes will come as I keep messing around with this stuff...
Type of change
Delete options that do not apply:
Checklist