Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CairoMakie not being able to plot exotic point arrays in lines #4668

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Dec 14, 2024

Description

Fixes #4661

Splits out the CairoMakie project_line_points into a main entry point that applies transform_func, and a second internal function.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 14, 2024

Benchmark Results

SHA: 367fcce5bae016d630b3a244441d11d244e18a75

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@asinghvi17
Copy link
Member Author

asinghvi17 commented Dec 14, 2024

Looks like this is a 12% performance hit if I just loosened the type constraint. The function barrier is probably a better option, then - with that I see a marginal improvement over the results on the master branch.

@asinghvi17 asinghvi17 marked this pull request as ready for review December 15, 2024 04:34
CairoMakie/src/utils.jl Outdated Show resolved Hide resolved
@SimonDanisch SimonDanisch merged commit 5c7aafa into master Dec 16, 2024
22 checks passed
@SimonDanisch SimonDanisch deleted the as/cairo_line_project branch December 16, 2024 10:27
@SimonDanisch
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

CairoMakie: lines fails if transform_func is not identity, and the input is not a pure Vector
4 participants