Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix violin indexing error #4682

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix violin indexing error #4682

wants to merge 4 commits into from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 18, 2024 •
edited
Loading

Description

Fixes #4675

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 18, 2024 •
edited
Loading

Benchmark Results

SHA: 4a680bfb112168a1be96307f0f4d1f41aa6cb549

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer ffreyer marked this pull request as ready for review December 18, 2024 23:25
@ffreyer ffreyer closed this Dec 18, 2024
@ffreyer ffreyer reopened this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR review
Status: Ready to review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

violin error
2 participants
@ffreyer @MakieBot