Pronto integration

[europ]

Pronto integration

Closes #192

Pronto supports a list of runners available in pronto/README.md which can be launched. To launch a runner, add the runner into Gemfile and require it properly in code_analysis_mixin.rb. The proper requiring is automated and now it is necessary to specify only the pronto gem.

It was necessary due to integration of pronto to create a same data structure from the pronto output as the original was. The integration was done in file app/workers/concerns/code_analysis_mixin.rb in run_all_linters method where is the code analysis launched via pronto and the result is formatted to match the originall pattern of the result structure.

Pronto result is an array of pronto messages which are iterated throught in order to create identical data structure of the former structure. The pronto_result method starts the pronto-runners a gather the informations and return an array of pronto messages. The run_all_linters method parses the array of pronto messages and creates a hash as the result. The hash structure contains all informations about the files inspected by pronto-runners which launch the corresponding linter.

---

• Due to some Pronto deficiencies few values are strictly defined, they were marked with TODO.
  NOTE: It was solved by removing theses variables (see the review comments below)

• Syntactic errors which are missing from the result of the Pronto-RuboCop will be solved by Fix for syntax error discarding prontolabs/pronto-rubocop#35

• Indention of the expected hash in code_analysis_mixin_spec.rb is extensive due to rubocop hash alignment correctness

• Informations about the position of the offence (column, line, length) are changed and from now line position is the only one supported because of request in comments below

---

\cc
@skateman
@romanblanco

[europ]

@miq-bot remove_label unmergeable

[miq-bot]

Checked commits europ/miq_bot@a7a279e~...7328482 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
8 files checked, 0 offenses detected
Everything looks fine. 🍪

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[NickLaMuro]

So looking into updating this, as it pushes us into the direction of getting #499 moving forward:

Aside from this conflicting with master, this also is having issues with the branch that I expect to be merged soon:

#498

There are a few weird down grades we are taking with dependent gems as a result:

Note: rainbow version regressed from 3.0.0 to 2.2.2
Note: thor version regressed from 1.0.1 to 0.19.4

(the above from the bundler output).

This is because of the pronto changes. Shouldn't be a big deal, but just a heads up. Currently trying to fix specs since regenerating the results.json files is not going smoothly at the moment...

[Fryguy]

Closing in favor of #500