Handle top-level patterns a bit better #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes them generate separate tags for the defined elements of the tuple, and removes newlines which result in invalid tag files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way that top-level pattern bindings are handled a bit, with two effects.
One, bindings like:
will generate separate tags for
x,yandzinstead of one monolithic tag. I only handled tuples here.Two, newlines are stripped out, so that code like:
No longer produces invalid tag files. I think this should be the case even if the separators aren't commas, but you won't get the nicer definition behavior above.
Should fix #85.