MDBF-786 - Make build output verbose, as a rule #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled VERBOSE=1 for quick builders.
|
Please can we try to determine (roughly) the amount of storage increase (db and artifact wise) that comes with this? |
@fauust Artifact wise shouldn't be a problem as this is the From my tests, the log output doubles (~1 more line per Make output) but I need to find out how to estimate the size. |
grooverdan
reviewed
Nov 6, 2024
| @@ -201,7 +201,7 @@ def getBuildFactoryPreTest(build_type="RelWithDebInfo", additional_args=""): | |||
| "additional_args", default=f"{additional_args}" | |||
| ), | |||
| create_package=util.Property("create_package", default="package"), | |||
| verbose_build=util.Property("verbose_build", default=""), | |||
| verbose_build=util.Property("verbose_build", default="VERBOSE=1"), | |||
There was a problem hiding this comment.
with #606 merged I think --output-sync=target can be added to this as no bintar builder uses f_quick_build.
RazvanLiviuVarzaru
force-pushed
the
dev
branch
from
d7eb898 to
4be5d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled VERBOSE=1 for quick builders as per request in MDBF-786.