MDEV-32686 Debian: include ELF package notes #3692
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grooverdan
force-pushed
the
10.11-MDEV-32686-deb-package-notes
branch
from
6fa05a9 to
25a2be2
Compare
grooverdan
added
the
MariaDB Foundation
ottok
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Nice! I didn't even know that this exists: https://manpages.debian.org/unstable/dh-package-notes/dh_package_notes.1.en.html
I do spot any issues or have concerns, approving.
|
PR description has still unchecked checkboxes
|
Providing build information compiled into the executable provides the ability of core file handlers to access information on the distro and source package version. This information can sometime be lost between the source and an upstream bug report. The Debian dh-package-notes includes the makefile included in debian/rules that sets linking flags to the right values. Add a small bit of safety that if the makefile isn't installed build anyway. ref: https://systemd.io/ELF_PACKAGE_METADATA/
grooverdan
force-pushed
the
10.11-MDEV-32686-deb-package-notes
branch
from
25a2be2 to
8a0a22d
Compare
grooverdan
changed the title
vuvova
reviewed
Dec 13, 2024
| @@ -131,6 +138,7 @@ in | |||
| "focal") | |||
| replace_uring_with_aio | |||
| disable_libfmt | |||
| remove_package_notes | |||
There was a problem hiding this comment.
why do you remove package notes in focal and bullseye? too old binutils?
There was a problem hiding this comment.
yes, but more directly not a dh-package-notes package that would use it.
| @@ -155,6 +163,10 @@ in | |||
| exit 1 | |||
| esac | |||
|
|
|||
| if [ ! -f /usr/share/debhelper/dh_package_notes/package-notes.mk ]; then | |||
| remove_package_notes | |||
There was a problem hiding this comment.
I don't think it's a good idea. This script builds release packages. They should be consistently built the way we want them to and not depend on whatever we forgot to install on a particular new builder. Better let it fail here — we'll see it and fix the builder — instead of us suddenly releasing the package that doesn't has what we want
grooverdan
added a commit
to grooverdan/mariadb-buildbot
that referenced
this pull request
Dec 18, 2024
Bootstrap this package build dependency into the CI images before server PR MariaDB/server#3692 is merged so autobake-deb builders contine to work. Can be removed once server commit merged up to main.
grooverdan
added a commit
to grooverdan/mariadb-buildbot
that referenced
this pull request
Dec 18, 2024
Bootstrap this package build dependency into the CI images before server PR MariaDB/server#3692 is merged so autobake-deb builders contine to work. Can be removed once server commit merged up to main. This excludes Debian 11 and Ubuntu focal
This tests the compile using a spec file. This spec file is defined by environment variables. If the spec file doesn't exist (SLES/OpenSUSE), isn't supported (e.g. clang), or has incorrect environment variables the linker flag won't be used.
grooverdan
force-pushed
the
10.11-MDEV-32686-deb-package-notes
branch
from
a4de93f to
9651d5d
Compare
|
RazvanLiviuVarzaru
pushed a commit
to MariaDB/buildbot
that referenced
this pull request
Dec 19, 2024
Bootstrap this package build dependency into the CI images before server PR MariaDB/server#3692 is merged so autobake-deb builders contine to work. Can be removed once server commit merged up to main. This excludes Debian 11 and Ubuntu focal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Providing build information compiled into the executable provides the ability of core file
handlers to access information on the distro and source package version. This information
can sometime be lost between the source and an upstream bug report.
The Debian dh-package-notes includes the makefile included in debian/rules that
sets linking flags to the right values.
ref: https://systemd.io/ELF_PACKAGE_METADATA/
Release Notes
Include OS information compiled into executables.
How can this PR be tested?
As buildbot workers don't have the dh-package-notes package installed yet:
Basing the PR against the correct MariaDB version
mainbranch.PR quality check