Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-35633 - Setting s3_protocol_version on MariaDB Server 10.5 has no effect #3695

Open
wants to merge 1 commit into
base: 10.5
Choose a base branch
from

Conversation

RazvanLiviuVarzaru
Copy link

  • The Jira issue number for this PR is: MDEV-35633

Description

Bump libmarias3 submodule to libmarias3-3.1.2-37-g289108f.

In libmarias3 3.1.2 (3846890), MS3_OPT_FORCE_PROTOCOL_VERSION overwrites the wrong variable hence s3_protocol_version has no effect, and will default to protocol_version 2 when using a hostname instead of an IP. This could lead to wrong request headers when using S3 providers that require the version 1 of the protocol.

This commit is only applicable to 10.5 branch and one should not apply it to newer versions because it will cause a downgrade of libmarias3.

Release Notes

Fixed a bug where s3_protocol_version had no effect on forcing the version.

How can this PR be tested?

Run MTR with --suite=s3, where protocol_version 1 (S3_PROTOCOL_VERSION=Original) is needed and use a hostname instead of an IP (for example: S3_HOST_NAME=minio.mariadb.org)

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

In libmarias3 3.1.2 (3846890), MS3_OPT_FORCE_PROTOCOL_VERSION overwrites the
wrong variable hence s3_protocol_version has no effect, and will default to
protocol_version 2 when using a hostname instead of an IP.
This could lead to wrong request headers when using S3 providers that require
the version 1 of the protocol.

This commit is only applicable to 10.5 branch and one should not apply it
to newer versions because it will cause a downgrade of libmarias3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants