MDEV-35633 - Setting s3_protocol_version on MariaDB Server 10.5 has no effect #3695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump libmarias3 submodule to libmarias3-3.1.2-37-g289108f.
In libmarias3 3.1.2 (3846890),
MS3_OPT_FORCE_PROTOCOL_VERSION
overwrites the wrong variable hences3_protocol_version
has no effect, and will default to protocol_version 2 when using a hostname instead of an IP. This could lead to wrong request headers when using S3 providers that require the version 1 of the protocol.This commit is only applicable to 10.5 branch and one should not apply it to newer versions because it will cause a downgrade of libmarias3.
Release Notes
Fixed a bug where s3_protocol_version had no effect on forcing the version.
How can this PR be tested?
Run MTR with
--suite=s3
, where protocol_version 1 (S3_PROTOCOL_VERSION=Original
) is needed and use a hostname instead of an IP (for example:S3_HOST_NAME=minio.mariadb.org
)Basing the PR against the correct MariaDB version
main
branch.PR quality check