MDEV-28649 json_array(false) in the definition of view return 0 inste… #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grooverdan
added
the
MariaDB Foundation
grooverdan
force-pushed
the
10.5-MDEV-28649
branch
from
4aaffae to
30c0d8a
Compare
…ad of "true" Using any boolean argument to a function in a view resulted in a view definition like: select json_array(0) AS `json_array(false)` This was imply the Item::print function used was from Item_int::print rather than a specific Item_bool::print function. Simplification to STRING_WITH_LEN noted from Alexey Botchkov's patch after almost equivalent implementation. Rather than EXPLAIN=JSON display "true", because its json, it doesn't need quotes. Adjust the json_write to identify boolean Items and then just print directly using add_bool.
grooverdan
force-pushed
the
10.5-MDEV-28649
branch
from
30c0d8a to
ccb6ca4
Compare
|
From @Olernov So there's minor test case result variants conflicts that everyone knows about that can be resolved by re-record by whoever merges last. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ad of "true"
Description
Using any boolean argument to a function in a view resulted in a view definition like:
select json_array(0) AS
json_array(false)This was imply the Item::print function used was from Item_int::print rather than a specific Item_bool::print function.
Simplification to STRING_WITH_LEN noted from Alexey Botchkov's patch after almost equivalent implementation.
6835d2ce268b001a9a4f85d92c132c58e33d490e
Explain FORMAT=JSON output to take boolean output rather than printing "true"/"false" in quotes.
Release Notes
View statements created with functions that take booleans now are accurately represented as booleans.
Also json output containing booleans are displayed as booleans.
How can this PR be tested?
test included
Basing the PR against the correct MariaDB version
mainbranch.PR quality check