Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow override of model default selects #912

Open
wants to merge 3 commits into
base: 2.0
Choose a base branch
from

Conversation

circulon
Copy link
Contributor

@circulon circulon commented Dec 1, 2024

This PR addresses generating queries with cusom select criteria or aggregation while also defining default select criteria in the model

This moves the addition of the default select columns from the creating the initial builder instance in the model to the querybuilder where checking if the defaults are actually required is done instead.

Additional Cleanup:

  • Removed some unused imports from tests
  • Removed some unused commented out parameters from tests
  • Sorted imports on some tests

Only use model get_selects() if no other columns are specified
Removed unused imports
Removed commented out unused paramers
Sorted imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant