-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new UFZ WANA ESI posititve spectra of 2018 mixes #237
Conversation
Interesting, that I committed 3 weeks ago :-/ |
Handling of empty COMMENT line to be checked in RMassBank (issue 348) |
@meier-rene, the formula is valid, because, we have a M+ ion. The validator is too restrictive in this case. I suggest to check the inner formula only.
I remove the M+ spectra until this is fixed in the validator. Added an issue |
…compounds correctly.
I analysed the situation with the brackets. The validator writes the brackets which is misleading. The underlying issue is that RMassBank does not calculate the charged formula, but the uncharged (and the curator did not check the infolist for this issue). Causing the error in the validation. Will add issue in RMassBank. |
Just a little bit of background: The validator uses the cdk to process formulas, inchi, smiles... If there is a charged molecule in the SMILES or InChI field and no charge in the formula field the validator will produce an error. The syntax for charged molecules in cdk is [Formula]Charge. This is a non ambiguous notation and I like it. Just consider a sulfate ion: [SO4]2- compared to SO42-. Can you produce that with R somehow? |
@meier-rene thanks for your comment. I will add the link to the new issue in RMassBank. |
No description provided.