fix: Missing schema properties (#78)

* Define `adGroupCriterion.systemServingStatus` property * Define `customer_id` property * Define `geographicView.resourceName` property * Define `campaignCriterion.bidModifier` property
Matatika · Jan 6, 2025 · 16993f7 · 16993f7
1 parent d09089f
commit 16993f7
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 0 deletions.
diff --git a/tap_googleads/schemas/campaign_performance_by_gender_and_device.json b/tap_googleads/schemas/campaign_performance_by_gender_and_device.json
@@ -65,6 +65,15 @@
                             "type": "string"
                         }
                     }
+                },
+                "systemServingStatus": {
+                    "type": "string",
+                    "enum": [
+                        "ELIGIBLE",
+                        "RARELY_SERVED",
+                        "UNKNOWN",
+                        "UNSPECIFIED"
+                    ]
                 }
             }
         },

diff --git a/tap_googleads/schemas/campaign_performance_by_location.json b/tap_googleads/schemas/campaign_performance_by_location.json
@@ -46,6 +46,9 @@
                     "properties": {
                         "geoTargetConstant": {
                             "type": "string"
+                        },
+                        "bidModifier": {
+                            "type": "number"
                         }
                     }
                 }

diff --git a/tap_googleads/schemas/geo_performance.json b/tap_googleads/schemas/geo_performance.json
@@ -46,6 +46,9 @@
         "geographicView": {
             "type": "object",
             "properties": {
+                "resourceName": {
+                    "type": "string"
+                },
                 "locationType": {
                     "type": "string"
                 },

diff --git a/tap_googleads/schemas/geo_target_constant.json b/tap_googleads/schemas/geo_target_constant.json
@@ -1,6 +1,9 @@
 {
     "type": "object",
     "properties": {
+        "customer_id": {
+            "type": "string"
+        },
         "geoTargetConstant": {
             "type": "object",
             "properties": {

diff --git a/tap_googleads/streams.py b/tap_googleads/streams.py
@@ -82,6 +82,7 @@ def gaql(self):
     replication_key = None
     parent_stream_type = AccessibleCustomers
     schema = th.PropertiesList(
+        th.Property("customer_id", th.StringType),
         th.Property(
             "customerClient",
             th.ObjectType(