Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPTIMADE v1.2.0-rc.1 release prep #430

Merged
merged 12 commits into from
Dec 22, 2022
Merged

OPTIMADE v1.2.0-rc.1 release prep #430

merged 12 commits into from
Dec 22, 2022

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 6, 2022

This PR is for preparing the organizational stuff around the v1.2.0-rc.1 release candidate.

  • Update schemas and their versions
    Currently I've just bumped the version number, we will need to wait a while for us to catch up with all these features in optimade-python-tools before the schema properly matches the spec.
  • Update CHANGELOG
  • Bump specification version numbers
  • Update contributors list
  • OPTIONAL: spruce up the README a bit with logo and updated links
  • Bump authors list
  • Final spelling audit

@ml-evs ml-evs added the blocking-release This is a PR or issue that presently blocks the release of next version of the spec. label Dec 6, 2022
@ml-evs ml-evs linked an issue Dec 20, 2022 that may be closed by this pull request
@ml-evs ml-evs linked an issue Dec 20, 2022 that may be closed by this pull request
@ml-evs ml-evs changed the title OPTIMADE v1.2 release prep OPTIMADE v1.2.0-rc.1 release prep Dec 22, 2022
@ml-evs ml-evs marked this pull request as ready for review December 22, 2022 17:53
@ml-evs
Copy link
Member Author

ml-evs commented Dec 22, 2022

@rartino this is the final PR required before rc.1, that includes mostly admin changes I made in preparation for 1.2.0, now adjusted for rc.1.

If you are happy to take a look at this before the holidays then I will release once it is merged.

I will also ping @merkys, @vaitkus and @JPBergsma in case they want to run through it, but I will consider your reviews optional :) There will also of course be the final PR that merges the 1.2-rc.1 into master as the new "released" version of the specification --- I will make this now on the assumption that this PR gets merged soon.

@ml-evs ml-evs added the priority/high There is a consensus that resolving this should be prioritized. label Dec 22, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
rartino
rartino previously approved these changes Dec 22, 2022
@ml-evs
Copy link
Member Author

ml-evs commented Dec 22, 2022

Thanks for the quick review @rartino! As I said in our final discussion, I will hold off the official release process until tomorrow evening, but I will merge this PR now so I can make the final develop->master PR. This could probably go without external review as I will not change anything in develop, but I will try to take the time to make sure there is nothing unexpected in it...

All that will then remain for rc.1 is:

  • Setting the git tag
  • Making the GitHub release (I'll copy the text from the CHANGELOG)

@ml-evs ml-evs requested a review from rartino December 22, 2022 18:15
AUTHORS Outdated Show resolved Hide resolved
Co-authored-by: Andrius Merkys <[email protected]>
Copy link
Contributor

@rartino rartino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important catch by @merkys ; but now it looks good to me.

@ml-evs
Copy link
Member Author

ml-evs commented Dec 22, 2022

Just a side note that the AUTHORS list still needs to be updated for the main release, but the CECAM website was down so I couldn't grab the attendee list for the last 2 workshops.

@ml-evs ml-evs merged commit fc0a0b9 into develop Dec 22, 2022
@ml-evs ml-evs deleted the 1.2_release_prep branch December 22, 2022 18:18
@JPBergsma
Copy link
Contributor

The CECAM website is online again. The list of participants can be found at https://www.cecam.org/workshop-details/1120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking-release This is a PR or issue that presently blocks the release of next version of the spec. priority/high There is a consensus that resolving this should be prioritized.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributors list needs to be updated OPTIMADE v1.2 release planning
5 participants