-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup common workflows for all GH repositories (public/private) #3
base: master
Are you sure you want to change the base?
Conversation
This is going to work for repositories that have the new |
So something I found is that the cobertura report is no longer properly generated. Actually coverage reports all just empty now. I actually don't remember when this was regressed on. It's possible that it has to do with the ESM changeover... right now not that important so skipping fixing this. |
So the check test job should look like this:
Here we can see we needed to add the I also added the JUnit report processor as we no longer have that automatic like in gitlab. |
So I have 3 jobs in the feature branch for library JS repos:
The check-build is a "feature" job that runs to sanity check that the build works. However we don't keep around the artifact do we? I guess it would depend on what is being built. That would be a the |
Ok so I've got We will see if it we can reference it properly. |
Description
We can reuse workflows defined here for all repos to avoid having to do so much repeat work when we are working on the workflows.
Issues Fixed
Tasks
Final checklist