gh-475-rename-requestsListConfig -> requestFilterConfig #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannaOCC
reviewed
Nov 6, 2024
giovannaOCC
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #gh-475
see: https://github.com/MauroDataMapper/sde-admin-ui/pull/209
and https://github.com/MauroDataMapper/sde-resources/pull/163 for details
from Issues:
When implementing the kanban board, I decoupled the request list filters (now RequestFilterComponent) from the rest of the component. I renamed the config enum to better reflect what it now does (From RequestsListMode => RequestFilterMode). I forgot to update this on mdm-explorer. This will fix the build issue when used with sde-resources #162 (https://github.com/MauroDataMapper/sde-resources/pull/163/
I considered reverting the name change but I decided to update this as I believe the old name no longer reflects which component its now used in and I want to keep to followable.