Allow OpenID Connect login from Micronaut #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-crawford
requested review from
pjmonks and
NigelPalmer
and removed request for
pjmonks
|
sorry @pjmonks requested your review by accident! |
NigelPalmer
requested changes
Dec 12, 2024
There was a problem hiding this comment.
I was able to sign in successfully and everything works as it should. I have raised some questions about the errors, but I don't think these questions are a reason not to merge this code.
I have not tested this against a micronaut implementation. I am just confirming that this all works fine with an mdm-core backend.
Reopening so questions can be answered.
src/app/security/open-id-connect-authorize/open-id-connect-authorize.component.ts
Show resolved
Hide resolved
src/app/security/open-id-connect-authorize/open-id-connect-authorize.component.ts
Show resolved
Hide resolved
NigelPalmer
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the same change as in the main UI in MauroDataMapper/mdm-ui#912 in order to allow login using OpenID Connect when using mauro-micronaut instead of mdm-core, which needed some tweaks as we're using Micronaut's provided OpenID plugin rather than our custom implementation.
Raising this PR even though we're still working on mauro-micronaut as want to keep all the UI code in one codebase.