Support generic type parameters #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Here's a screenshot of the type-hint you get in vs-code while hovering over the |
|
@MaxLeiter I don't know if you saw this. It should be pretty quick to review if you're interested in taking a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enables type checking scoped slots, and by extension, lets developers get type completions while writing the #item slot.
There is a "breaking change" to consider here: to access the type of the component, we can no longer use
InstanceType<typeof sortable>, because it doesn't work with generic components. We have to replaceInstanceTypewithComponentExposedas described in this issue: Cannot use InstanceType<typeof Comp>> on generic components.This requires adding 'vue-component-type-helpers' (from the official Vue Language Tools repository) as a dev dependency.