-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out of source build development #121
base: development
Are you sure you want to change the base?
Out of source build development #121
Conversation
35bc548
to
d93d138
Compare
} | ||
|
||
component_test_tf_psa_crypto_cmake_as_subdirectory () { | ||
msg "build: cmake 'as-subdirectory' build" | ||
cd programs/test/cmake_subproject | ||
cd "$TF_PSA_CRYPTO_ROOT_DIR/programs/test/cmake_subproject" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd "$TF_PSA_CRYPTO_ROOT_DIR/programs/test/cmake_subproject" | |
cd programs/test/cmake_subproject |
@@ -34,7 +30,7 @@ component_test_tf_psa_crypto_cmake_as_subdirectory () { | |||
|
|||
component_test_tf_psa_crypto_cmake_as_package_install () { | |||
msg "build: cmake 'as-installed-package' build" | |||
cd programs/test/cmake_package_install | |||
cd $TF_PSA_CRYPTO_ROOT_DIR/programs/test/cmake_package_install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd $TF_PSA_CRYPTO_ROOT_DIR/programs/test/cmake_package_install | |
cd programs/test/cmake_package_install |
In the CI, the three TF-PSA-Crypto components fail. I think this is because of:
in |
I don't think this is complicated to resolve: this block of code was written based on the assumption that we wanted tf-psa-crypto to use the framework from Mbed TLS - but that's not the direction we're taking now. (Also, something had to be done because the framework subdir of tf-psa-crypto did not exist when that code was written.) So, I'd suggest simply replacing the quoted |
bc2f4e9
to
5793984
Compare
This commit removes duplicate code to build TF-PSA-Crypto out of source which has now been moved to mbedtls-framework. Signed-off-by: Harry Ramsey <[email protected]>
f6f62f8
to
ebfcd14
Compare
This commit updates the framework submodule to include commits relevant to running TF-PSA-Crypto using CMake build system. Signed-off-by: Harry Ramsey <[email protected]>
ebfcd14
to
6fe6d7a
Compare
Description
Closes #9755
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: