Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check recursion and check test cases all.sh components #94

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

tom-daubney-arm
Copy link
Contributor

Fixes #53

This PR adds the all.sh components for check_recursion and check_test_cases and adds recursion.pl to the list of scripts to copy in psa_crypto.py.

Add components for check_recursion and check_test_cases.

Signed-off-by: Thomas Daubney <[email protected]>
@tom-daubney-arm tom-daubney-arm added enhancement New feature or request needs-review Every commit must be reviewed by at least two team members priority-high High priority - will be reviewed soon labels Dec 11, 2023
@tom-daubney-arm tom-daubney-arm linked an issue Dec 11, 2023 that may be closed by this pull request

component_check_recursion () {
msg "Check: recursion.pl" # < 1s
tests/scripts/recursion.pl library/*.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library/*.c is not suitable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to change that to core and I clearly forgot.

@@ -209,7 +209,7 @@ component_test_cmake_shared () {

component_check_recursion () {
msg "Check: recursion.pl" # < 1s
tests/scripts/recursion.pl library/*.c
tests/scripts/recursion.pl core/*.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to check also the drivers C files.

Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-review Every commit must be reviewed by at least two team members priority-high High priority - will be reviewed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add misc basic checks all.sh components
3 participants