Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move most of min_requirements.py to the framework #105

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move most of min_requirements.py to the framework #105

wants to merge 3 commits into from

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Dec 19, 2024 •
edited
Loading

Description

Resolves issue #86

development PR: Mbed-TLS/mbedtls#9863
mbedtls-3.6 PR: Mbed-TLS/mbedtls#9864

PR checklist

Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.

  • crypto PR Mbed-TLS/TF-PSA-Crypto#
  • development PR Mbed-TLS/mbedtls#
  • 3.6 PR Mbed-TLS/mbedtls#

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

valeriosetti and others added 3 commits December 19, 2024 12:17
@valeriosetti
Move files into the framework
8e88f34 
The following files are added (imported) from the main Mbed TLS repo:

scripts/mbedtls_framework/min_requirements.py

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti
Merge branch 'tmp-branch-move-files-to-framework' into issue86-framework
37f923f
@valeriosetti
scripts: min_requirements.py: small changes to work as module
50bdc2e 
- prevent the file from being called directly from the command line;
- allow to pass in the default requirement file so that each repo
  can specify its own version.

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti mentioned this pull request Dec 19, 2024
Open
5 tasks
@valeriosetti valeriosetti added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Dec 19, 2024
@valeriosetti valeriosetti mentioned this pull request Dec 19, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@valeriosetti