Add sanitizer build option when building a file #27
Conversation
Sanitizer presence can be checked in the library and can cause build error if missing. Signed-off-by: Gabor Mezei <[email protected]>
gabor-mezei-arm
added
bug
There was a problem hiding this comment.
Originally c_build_helper was only used as part of make generated_files, in scripts that expect the original configuration but also work if a different set of options are commented out. I wonder if we should focus on that objective or instead make the code more general. This pull request makes the code more general, but I wonder if this is the right direction.
One thing that's been bothering me (and some users) is that this script assumes a native C compiler, but honors CC and now CFLAGS. It was a deliberate choice not to honor CFLAGS to make it work at least in some cases of cross compilation (if your CC is a multi-architecture compiler like clang, and it's CFLAGS that causes the compilation to be cross-compilation).
Maybe instead of fiddling with CFLAGS, we should instead act on the configuration, and try to ensure that the compilation runs in a “good” configuration?
How did this problem come up anyway? Trying to run make generated_files with a modified configuration? (That doesn't always work, which is why I almost always do my non-default-configuration builds by setting MBEDTLS_CONFIG_FILE or using an extra include directory containing mbedtls/mbedtls_config.h, instead of editing include/mbedtls/mbedtls_config.h.)
| # When using cmake the sanitizer usage can be read from the cache file. | ||
| if os.path.isfile(CMAKE_CACHE_FILE): | ||
| with open(CMAKE_CACHE_FILE, 'r', encoding='utf-8') as file: | ||
| m = re.findall(CMAKE_SANITIZER_REGEXP, file.read(), re.DOTALL) |
There was a problem hiding this comment.
Why re.findall and not re.search since we only use the first hit?
Add the
-fsanitizebuild option for C file building in the scripts.When
MBEDTLS_TEST_CONSTANT_FLOW_MEMSANis set, thecheck_config.hhave a check for the memory sanitizer is enabled in the compiler. This can cause build error when reading the configuration from the scripts.