feat: Add output_path property, and streamline implementation
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
output-path
branch
3 times, most recently
from
fc54324 to
b28bf07
Compare
|
Thank you for unblocking CI. 👍 |
edgarrmondragon
requested changes
Dec 18, 2023
amotl
force-pushed
the
output-path
branch
3 times, most recently
from
f1a0fed to
61ecf7a
Compare
error: Argument 1 to "__init__" of "Sink" has incompatible type "PluginBase"; expected "Target" [arg-type]
Users got confused about the semantics of the `output_path_prefix` property. This patch makes it better by renaming it to `output_path`, while still providing backwards-compatibility. Further, the `destination_path` property can also be used as an alias, thus this target can be a drop-in replacement to the `hotgluexyz` variant. The value of the variable does not need to be configured using a trailing slash any longer. Instead, the implementation more thoroughly leverages `pathlib.Path` for concatenating `output_path` and `filename`.
|
edgarrmondragon
approved these changes
Dec 18, 2023
This was referenced Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Users got confused about the semantics of the
output_path_prefixproperty. This patch makes it better by renaming it tooutput_path, while still providing backwards-compatibility.Further, the
destination_pathproperty can also be used, thus this target can be a drop-in replacement to thehotgluexyzvariant.The value of the variable does not need to be configured using a trailing slash any longer. Instead, the implementation more thoroughly leverages
pathlib.Pathfor concatenatingoutput_pathandfilename.References
Thoughts
I am not sure about fc54324. I added it because mypy tripped like described in the commit message. Please educate me if that was wrong, so I will either remove it or amend it correspondingly.