Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1346 deal with change in semantics for queue declares from previous versions. #1349

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

petersilva
Copy link
Contributor

there is a change in required order in configuration files that needs to happen because in future, there will be support for connections to multiple queues and multiple brokers from the same subscriber.

For current versions, this means parameters applied to queues need to be earlier in the file than when queue settings get resolved. This happens when the parser reaches as subtopic setting. So in this set of patches:

  • in sr3 convert... move the affected options to the front of the file ... since v2 only supported single queues, this is good.
  • in config parser, make a warning message for when settings show up in a fishy place... after subtopic.
  • add some hints in the reference about ordering constraints.

Copy link

Test Results

5 tests   0 ✅  18s ⏱️
1 suites  0 💤
1 files    0 ❌  5 🔥

For more details on these errors, see this check.

Results for commit 6f7337e.

@petersilva petersilva marked this pull request as ready for review December 17, 2024 20:38
@petersilva petersilva merged commit 5dcce05 into development Dec 18, 2024
42 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants