Fix DiskQueue bugs #1356
Merged
Fix DiskQueue bugs #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results239 tests 234 ✅ 1m 40s ⏱️ For more details on these failures, see this check. Results for commit 727bbe4. ♻️ This comment has been updated with latest results. |
…sl incompatibility
|
i also changed the unit test github actions to run on Ubuntu 24.04. This fixed these errors: But the unit tests are failing (not related to the diskqueue) |
petersilva
approved these changes
Dec 20, 2024
|
I made the unit tests work with the old pre-June code, then checked out the June changes and confirmed that it broke my new tests, then fixed the diskqueue code until the unit tests passed again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to make the flakey test somewhat reliable again, even without the poll changes that I'm still experimenting with separately.